From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Wed, 6 Apr 2011 18:50:25 -0400 Subject: [U-Boot] [PATCH v2 5/6] phylib: Add a bunch of PHY drivers from tsec In-Reply-To: <1302040794-19837-6-git-send-email-afleming@freescale.com> References: <1302040794-19837-1-git-send-email-afleming@freescale.com> <1302040794-19837-5-git-send-email-afleming@freescale.com> <1302040794-19837-6-git-send-email-afleming@freescale.com> Message-ID: <201104061850.26414.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, April 05, 2011 17:59:53 Andy Fleming wrote: > --- a/include/phy.h > +++ b/include/phy.h > +int atheros_init(void); > +int broadcom_init(void); > +int davicom_init(void); > +int lxt_init(void); > +int marvell_init(void); > +int micrel_init(void); > +int natsemi_init(void); > +int realtek_init(void); > +int teranetics_init(void); > +int vitesse_init(void); imo, these should have a "phy_" prefix on their names. these are pretty generic otherwise. > diff --git a/include/phylib_all_drivers.h b/include/phylib_all_drivers.h this probably should be prefixed with a "config_" to match the existing header filename style. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20110406/d39a2262/attachment.pgp