From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Thu, 7 Apr 2011 00:47:27 -0400 Subject: [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot In-Reply-To: <20110407044344.C88C01537B0@gemini.denx.de> References: <1302040794-19837-1-git-send-email-afleming@freescale.com> <1302040794-19837-5-git-send-email-afleming@freescale.com> <20110407044344.C88C01537B0@gemini.denx.de> Message-ID: <201104070047.28480.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday, April 07, 2011 00:43:44 Wolfgang Denk wrote: > Andy Fleming wrote: > > +#define SUPPORTED_10baseT_Half (1 << 0) > > +#define SUPPORTED_10baseT_Full (1 << 1) > > +#define SUPPORTED_100baseT_Half (1 << 2) > > +#define SUPPORTED_100baseT_Full (1 << 3) > > +#define SUPPORTED_1000baseT_Half (1 << 4) > > +#define SUPPORTED_1000baseT_Full (1 << 5) > > +#define SUPPORTED_Autoneg (1 << 6) > > +#define SUPPORTED_TP (1 << 7) > > +#define SUPPORTED_AUI (1 << 8) > > +#define SUPPORTED_MII (1 << 9) > > +#define SUPPORTED_FIBRE (1 << 10) > > +#define SUPPORTED_BNC (1 << 11) > > +#define SUPPORTED_10000baseT_Full (1 << 12) > > +#define SUPPORTED_Pause (1 << 13) > > +#define SUPPORTED_Asym_Pause (1 << 14) > > +#define SUPPORTED_2500baseX_Full (1 << 15) > > +#define SUPPORTED_Backplane (1 << 16) > > +#define SUPPORTED_1000baseKX_Full (1 << 17) > > +#define SUPPORTED_10000baseKX4_Full (1 << 18) > > +#define SUPPORTED_10000baseKR_Full (1 << 19) > > +#define SUPPORTED_10000baseR_FEC (1 << 20) > > We don't allow for CamelCaps identifiers or macro names. Macros are > all caps, please. Please fix globally. these are taken straight from Linux which makes code sharing a lot easier -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20110407/8db57cf3/attachment.pgp