public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cfi_flash: reverse geometry for M29W800DT parts
Date: Mon, 11 Apr 2011 02:01:22 +0200	[thread overview]
Message-ID: <201104110201.23066.marek.vasut@gmail.com> (raw)
In-Reply-To: <1302465989-23952-1-git-send-email-vapier@gentoo.org>

On Sunday 10 April 2011 22:06:29 Mike Frysinger wrote:
> The M29W800DT parts also report their geometry with the sector layout
> reversed.  So add that ID to the flash_fixup_stm function.

Maybe rework the stuff below into some table or it'll be a mess soon?

Cheers

> 
> Otherwise, we get:
> bfin> flinfo
> 
> Bank # 1: CFI conformant FLASH (16 x 16)  Size: 1 MB in 19 Sectors
>   AMD Standard command set, Manufacturer ID: 0x20, Device ID: 0x22D7
>   Erase timeout: 8192 ms, write timeout: 1 ms
> 
>   Sector Start Addresses:
>   20000000        20004000        20006000        20008000        20010000
>   20020000        20030000        20040000        20050000        20060000
>   20070000        20080000        20090000        200A0000        200B0000
>   200C0000        200D0000        200E0000        200F0000
> 
> Reported-by: Jianxi Fu <fujianxi@gmail.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  drivers/mtd/cfi_flash.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
> index 0909fe7..69f12d3 100644
> --- a/drivers/mtd/cfi_flash.c
> +++ b/drivers/mtd/cfi_flash.c
> @@ -1852,9 +1852,10 @@ static void flash_fixup_stm(flash_info_t *info,
> struct cfi_qry *qry) if (qry->num_erase_regions > 1) {
>  		/* reverse geometry if top boot part */
>  		if (info->cfi_version < 0x3131) {
> -			/* CFI < 1.1, guess by device id (M29W320{DT,ET} only) */
> -			if (info->device_id == 0x22CA ||
> -			    info->device_id == 0x2256) {
> +			/* CFI < 1.1, guess by device id */
> +			if (info->device_id == 0x22CA || /* M29W320DT */
> +			    info->device_id == 0x2256 || /* M29W320ET */
> +			    info->device_id == 0x22D7) { /* M29W800DT */
>  				cfi_reverse_geometry(qry);
>  			}
>  		}

  reply	other threads:[~2011-04-11  0:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-10 20:06 [U-Boot] [PATCH] cfi_flash: reverse geometry for M29W800DT parts Mike Frysinger
2011-04-11  0:01 ` Marek Vasut [this message]
2011-04-21 13:54 ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201104110201.23066.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox