public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] Env and lds file clean up for ColdFire M5445x and M547x/8x boards.
Date: Tue, 12 Apr 2011 12:13:34 +0200	[thread overview]
Message-ID: <20110412101334.2F41D151F83@gemini.denx.de> (raw)
In-Reply-To: <1302597610-15646-4-git-send-email-Jason.jin@freescale.com>

Dear Jason Jin,

In message <1302597610-15646-4-git-send-email-Jason.jin@freescale.com> you wrote:
> Move the environment outside the u-boot image, leave more
>  space for the text to avoid the possible PC truncate issue.
> 
>  The lds file for ColdFire need to clean up since commit
>  6d8962e814c15807dd6ac5757904be2a02d187b8 'Switch from archive
>  libraries to partial linking'.
...
>  /*
>   * Configuration for environment
> - * Environment is embedded in u-boot in the second sector of the flash
> + * Environment is not embedded in u-boot. First time runing may have env crc error warnig
> + * if there are no correct environment on the flash.

Line too long.

> +#define CONFIG_SYS_MALLOC_LEN		(256 << 10)	/* Reserve 256 kB for malloc() */

Ditto. Please fix globally!


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Documentation is like sex: when it is good, it is  very,  very  good;
and when it is bad, it is better than nothing.         - Dick Brandon

  parent reply	other threads:[~2011-04-12 10:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12  8:40 [U-Boot] [patch 0/6] Update patchset for some Freescale ColdFire boards Jason Jin
2011-04-12  8:40 ` [U-Boot] [PATCH 1/6] Fix the configuration broken for " Jason Jin
2011-04-12  8:40   ` [U-Boot] [PATCH 2/6] Fix the CPP flags for toolchain 4.4.1 on " Jason Jin
2011-04-12  8:40     ` [U-Boot] [PATCH 3/6] Env and lds file clean up for ColdFire M5445x and M547x/8x boards Jason Jin
2011-04-12  8:40       ` [U-Boot] [PATCH 4/6] Clean up lds files for some ColdFire nommu chips Jason Jin
2011-04-12  8:40         ` [U-Boot] [PATCH 5/6] Enable the dm9000 on ColdFire 5253DEMO board Jason Jin
2011-04-12  8:40           ` [U-Boot] [PATCH 6/6] Disable the NFS define for 52277 board Jason Jin
2011-04-12 10:17           ` [U-Boot] [PATCH 5/6] Enable the dm9000 on ColdFire 5253DEMO board Wolfgang Denk
2011-04-12 10:13       ` Wolfgang Denk [this message]
2011-04-12 10:15     ` [U-Boot] [PATCH 2/6] Fix the CPP flags for toolchain 4.4.1 on ColdFire boards Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110412101334.2F41D151F83@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox