From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4 4/4] VCMA9: various cleanups/code style fixes
Date: Tue, 12 Apr 2011 12:28:01 +0200 [thread overview]
Message-ID: <20110412102802.23B73151F83@gemini.denx.de> (raw)
In-Reply-To: <1302600759-28219-5-git-send-email-d.mueller@elsoft.ch>
Dear =?UTF-8?q?David=20M=C3=BCller?=,
In message <1302600759-28219-5-git-send-email-d.mueller@elsoft.ch> you wrote:
> --===============1758926862==
>
> Signed-off-by: David M??ller <d.mueller@elsoft.ch>
>
> ---
> board/mpl/vcma9/cmd_vcma9.c | 4 +-
> board/mpl/vcma9/lowlevel_init.S | 549 ++++++++++++++++++++++++++++++---------
> board/mpl/vcma9/vcma9.c | 272 +++++---------------
> board/mpl/vcma9/vcma9.h | 117 +--------
> include/configs/VCMA9.h | 200 +++++++++------
> 5 files changed, 626 insertions(+), 516 deletions(-)
Where is the change log that shows what has been changed with this new
patch version? Please see
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
> -extern void print_vcma9_info(void);
> +extern void vcma9_print_info(void);
Please get rid of all such externs - move the prototype declarations
to appropriate header files. Please fix globally.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is impractical for the standard to attempt to constrain the
behavior of code that does not obey the constraints of the standard.
- Doug Gwyn
next prev parent reply other threads:[~2011-04-12 10:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 10:09 [U-Boot] [PATCH] update VCMA9 port David Müller
2011-01-09 21:24 ` Wolfgang Denk
2011-01-10 8:13 ` "David Müller (ELSOFT AG)"
2011-01-11 7:47 ` [U-Boot] [PATCH V2] " David Müller
2011-01-11 9:36 ` Wolfgang Denk
2011-01-11 12:22 ` [U-Boot] [PATCH V3] " David Müller
2011-02-01 8:35 ` [U-Boot] [PING] " "David Müller (ELSOFT AG)"
2011-03-01 8:00 ` [U-Boot] [PING #2] " "David Müller (ELSOFT AG)"
2011-03-02 2:28 ` [U-Boot] " Minkyu Kang
2011-04-11 19:24 ` Wolfgang Denk
2011-04-12 1:21 ` Minkyu Kang
2011-04-12 9:32 ` [U-Boot] [PATCH V4] " David Müller
2011-04-12 9:32 ` [U-Boot] [PATCH V4 1/4] VCMA9: activate ARM relocation feature David Müller
2011-04-12 10:30 ` Wolfgang Denk
2011-04-12 10:32 ` Wolfgang Denk
2011-04-12 9:32 ` [U-Boot] [PATCH V4 2/4] VCMA9: remove unneeded config.mk David Müller
2011-04-12 9:32 ` [U-Boot] [PATCH V4 3/4] VCMA9: use the CFI driver (and remove the old one) David Müller
2011-04-12 9:32 ` [U-Boot] [PATCH V4 4/4] VCMA9: various cleanups/code style fixes David Müller
2011-04-12 10:28 ` Wolfgang Denk [this message]
2011-05-02 7:52 ` [U-Boot] [PATCH V5 0/4] update VCMA9 port David Müller
2011-05-02 7:52 ` [U-Boot] [PATCH V5 1/4] VCMA9: use ARM relocation feature to fix build error David Müller
2011-05-02 7:52 ` [U-Boot] [PATCH V5 2/4] VCMA9: remove unneeded config.mk David Müller
2011-05-02 7:52 ` [U-Boot] [PATCH V5 3/4] VCMA9: use CFI driver (and remove the old one) David Müller
2011-05-02 7:52 ` [U-Boot] [PATCH V5 4/4] VCMA9: various cleanups/code style fixes David Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412102802.23B73151F83@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox