public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] e1000: Restructure and streamline PCI device probing
Date: Tue, 12 Apr 2011 22:17:51 +0200	[thread overview]
Message-ID: <20110412201751.4F36A1537B0@gemini.denx.de> (raw)
In-Reply-To: <1297467482-14864-3-git-send-email-Kyle.D.Moffett@boeing.com>

Dear Kyle Moffett,

In message <1297467482-14864-3-git-send-email-Kyle.D.Moffett@boeing.com> you wrote:
> By allocating the e1000 device structures much earlier, we can easily
> generate better error messages and siginficantly clean things up.
> 
> The only user-visable change (aside from reworded error messages) is
> that a detected e1000 device which fails to initialize due to software
> or hardware error will still be allocated a device number.
> 
> As one example, consider a system with 2 e1000 PCI devices where the
> first controller has a corrupted EEPROM.  Using the old code the
> second controller would be "e1000#0", while with this change it would be
> "e1000#1".
> 
> This change should hopefully make such EEPROM errors much more
> straightforward to handle correctly in boot scripts and the like.
> 
> It is also necessary for a followup patch which allows SPI programming
> of an e1000 controller's EEPROM even if the checksum is invalid.

This patch has a number of overlong lines.  Please globally fix the
line length.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To be is to program.

  reply	other threads:[~2011-04-12 20:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11 23:37 [U-Boot] e1000: Driver additions for eXMeritus HWW-1U-1A Kyle Moffett
2011-02-11 23:37 ` [U-Boot] [PATCH 1/5] e1000: Clean up handling of dual-port NICs and support 82571 Kyle Moffett
2011-02-11 23:37 ` [U-Boot] [PATCH 2/5] e1000: Restructure and streamline PCI device probing Kyle Moffett
2011-04-12 20:17   ` Wolfgang Denk [this message]
2011-04-12 22:56     ` Moffett, Kyle D
2011-04-13  5:13       ` Wolfgang Denk
2011-02-11 23:38 ` [U-Boot] [PATCH 3/5] e1000: Rewrite EEPROM checksum error to give more information Kyle Moffett
2011-02-11 23:38 ` [U-Boot] [PATCH 4/5] e1000: New "e1000" commands for SPI EEPROM management Kyle Moffett
2011-04-12 20:24   ` Wolfgang Denk
2011-04-12 23:26     ` Moffett, Kyle D
2011-04-13  5:23       ` Wolfgang Denk
2011-04-13 14:54         ` Moffett, Kyle D
2011-02-11 23:38 ` [U-Boot] [PATCH 5/5] e1000: Add a small SPI driver wrapper around the EEPROM code Kyle Moffett
2011-04-12 20:25   ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2011-10-18 21:05 [U-Boot] [PATCH 0/5] HWW-1U-1A: e1000 driver cleanups and new features Kyle Moffett
2011-10-18 21:05 ` [U-Boot] [PATCH 2/5] e1000: Restructure and streamline PCI device probing Kyle Moffett
2011-10-27 22:34   ` Wolfgang Denk
2010-09-13 15:52 [U-Boot] [PATCH 1/5] e1000: Clean up handling of dual-port NICs and support 82571 Kyle Moffett
2010-09-13 15:52 ` [U-Boot] [PATCH 2/5] e1000: Restructure and streamline PCI device probing Kyle Moffett
2010-11-14 23:04   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110412201751.4F36A1537B0@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox