From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/5] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter
Date: Tue, 12 Apr 2011 23:44:43 -0400 [thread overview]
Message-ID: <201104122344.43815.vapier@gentoo.org> (raw)
In-Reply-To: <1302655572-31544-1-git-send-email-sjg@chromium.org>
On Tuesday, April 12, 2011 20:46:08 Simon Glass wrote:
> +static int turbo_mode = 1;
perhaps this should be a #define ? i cant see anything that changes its value
in this driver ...
> +static void smsc95xx_halt(struct eth_device *eth)
> +{
> + debug("** %s()\n", __func__);
> +}
is this right ? shouldnt you be halting something ?
> +/*
> + * SMSC probing functions
> + */
> +void smsc95xx_eth_before_probe(void)
> +{
> + curr_eth_dev = 0;
> +}
curr_eth_dev is declared static which means it starts off with a value of 0.
when does before_probe get called ? just once ever during the execution of u-
boot ? i guess this func should get tossed if that's the case.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110412/88b6bd4c/attachment.pgp
next prev parent reply other threads:[~2011-04-13 3:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 0:46 [U-Boot] [PATCH v2 1/5] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter Simon Glass
2011-04-13 0:46 ` [U-Boot] [PATCH v2 2/5] Add Ethernet hardware MAC address framework to usbnet Simon Glass
2011-04-13 3:48 ` Mike Frysinger
2011-04-13 20:23 ` Albert ARIBAUD
2011-04-13 20:28 ` Simon Glass
2011-04-13 21:05 ` Mike Frysinger
2011-04-14 5:01 ` Albert ARIBAUD
2011-04-13 23:30 ` Mike Frysinger
2011-04-14 5:58 ` Albert ARIBAUD
2011-04-14 6:12 ` Mike Frysinger
2011-04-14 6:51 ` Albert ARIBAUD
2011-04-15 7:56 ` Mike Frysinger
2011-04-15 8:13 ` Albert ARIBAUD
2011-04-15 8:25 ` Mike Frysinger
2011-04-15 9:34 ` Albert ARIBAUD
2011-04-13 0:46 ` [U-Boot] [PATCH v2 3/5] Add documentation for USB Host Networking Simon Glass
2011-04-13 0:46 ` [U-Boot] [PATCH v2 4/5] Put common autoload code into AutoLoad() function Simon Glass
2011-04-13 0:46 ` [U-Boot] [PATCH v2 5/5] Allow tftp server to be different from bootp/dhcp server Simon Glass
2011-04-13 3:44 ` Mike Frysinger [this message]
2011-04-13 18:47 ` [U-Boot] [PATCH v2 1/5] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter Simon Glass
2011-04-13 19:45 ` Wolfgang Denk
2011-04-13 21:13 ` Simon Glass
2011-04-13 21:21 ` Simon Glass
2011-04-13 21:43 ` Simon Glass
2011-04-13 21:50 ` Wolfgang Denk
2011-04-13 21:08 ` Mike Frysinger
2011-04-13 22:31 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104122344.43815.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox