public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/4] generic mmc_spi driver
Date: Wed, 13 Apr 2011 15:46:22 -0400	[thread overview]
Message-ID: <201104131546.23464.vapier@gentoo.org> (raw)
In-Reply-To: <BANLkTim6pXwsEBo+7S-fefd2VsdwnpS2kw@mail.gmail.com>

On Wednesday, April 13, 2011 06:17:43 Andy Fleming wrote:
> On Tue, Apr 12, 2011 at 1:58 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Friday, December 24, 2010 02:16:05 Thomas Chou wrote:
> >> This is the v9 update of the mmc_spi driver. Please enable DEBUG on the
> >> top of mmc_spi.c and help me perform the tests.
> >> 
> >> A new spi_set_speed() is added to meet the 400KHz clock requirement
> >> during mmc card initialization. An example update to bfin_spi is
> >> included. The altera_spi core does not support speed change, so I am
> >> going to post a new opencore ip for this.
> >> 
> >> The driver now claims and releases the spi bus for each mmc command, as
> >> Mike suggested.
> >> 
> >> Thomas Chou (4):
> >>   lib: add crc7 from Linux
> >>   spi: add spi_set_speed func
> >>   bfin_spi: add spi_set_speed
> >>   mmc: add generic mmc spi driver
> > 
> > Andy: i think we've hit a fairly stable point.  could you merge this now
> > ?
> 
> I'm going to merge this, but I'll note that the reason you had to run
> mmcinfo before this will work is because this code never invoks
> mmc_init().  If you look at the mmc command in common/cmd_mmc.c, and
> see how the various sub-commands operate (under GENERIC_MMC), all of
> them call mmc_init() before running the command.  It's suboptimal in
> terms of performance, but has the advantage of being robust and
> actually detecting if you put a card in, or took one out. If someone
> could find the appropriate places to call mmc_init(mmc), I'll be happy
> to also merge in the follow-up patch.

i hope Thomas can do that :)

> Also, I'm assuming, at the moment, that this supersedes the legacy
> mmc_spi patch you submitted earlier? If not, I'll put that in, now,
> too.

correct, the legacy mmc_spi code is hopefully no longer needed
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110413/ea65099d/attachment.pgp 

  reply	other threads:[~2011-04-13 19:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-24  7:16 [U-Boot] [PATCH 0/4] generic mmc_spi driver Thomas Chou
2010-12-24  7:16 ` [U-Boot] [PATCH 1/4] lib: add crc7 from Linux Thomas Chou
2011-01-10 20:59   ` Wolfgang Denk
2011-01-11  1:38     ` [U-Boot] [PATCH v2] " Thomas Chou
2011-01-18 22:38       ` Wolfgang Denk
2010-12-24  7:16 ` [U-Boot] [PATCH 2/4] spi: add spi_set_speed func Thomas Chou
2010-12-24 17:09   ` Mike Frysinger
2010-12-24 23:13   ` [U-Boot] [PATCH 2/4 v2] " Thomas Chou
2011-01-18 22:37     ` Wolfgang Denk
2011-01-19  1:34       ` [U-Boot] [PATCH 2/4 v3] " Thomas Chou
2010-12-24  7:16 ` [U-Boot] [PATCH 3/4] bfin_spi: add spi_set_speed Thomas Chou
2010-12-24 17:25   ` Mike Frysinger
2010-12-24  7:16 ` [U-Boot] [PATCH 4/4] mmc: add generic mmc spi driver Thomas Chou
2010-12-24 23:12   ` [U-Boot] [PATCH 4/4 v10] " Thomas Chou
2010-12-24 17:24 ` [U-Boot] [PATCH 0/4] generic mmc_spi driver Mike Frysinger
2010-12-24 19:06   ` Reinhard Meyer
2010-12-24 19:45     ` Mike Frysinger
2010-12-24 23:21       ` Thomas Chou
2011-04-12  6:58 ` Mike Frysinger
2011-04-13 10:17   ` Andy Fleming
2011-04-13 19:46     ` Mike Frysinger [this message]
2011-04-18  7:00     ` [U-Boot] [PATCH] mmc_spi: add mmc_init call Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201104131546.23464.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox