public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/5] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter
Date: Wed, 13 Apr 2011 21:45:18 +0200	[thread overview]
Message-ID: <20110413194518.546CBCF@gemini.denx.de> (raw)
In-Reply-To: <BANLkTinacFQ=1xA4PTgZKi5ON9AGG7-Jwg@mail.gmail.com>

Dear Simon Glass,

In message <BANLkTinacFQ=1xA4PTgZKi5ON9AGG7-Jwg@mail.gmail.com> you wrote:
>
> >> +static void smsc95xx_halt(struct eth_device *eth)
> >> +{
> >> +     debug("** %s()\n", __func__);
> >> +}
> >
> > is this right ?  shouldnt you be halting something ?
> 
> I could do, but halting is not in the driver at present. Do you think
> it is important?

Yes, it is important to shut down devices.  Especially with USB
devices.

BTW: can you *please* fix your mail addresses?
It's not "Remy Bohmerl <inux@bohmer.net>"
but "Remy Bohmer <linux@bohmer.net>" instead.  Don't you get tons of
bounce messages?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every living thing wants to survive.
	-- Spock, "The Ultimate Computer", stardate 4731.3

  reply	other threads:[~2011-04-13 19:45 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-13  0:46 [U-Boot] [PATCH v2 1/5] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter Simon Glass
2011-04-13  0:46 ` [U-Boot] [PATCH v2 2/5] Add Ethernet hardware MAC address framework to usbnet Simon Glass
2011-04-13  3:48   ` Mike Frysinger
2011-04-13 20:23     ` Albert ARIBAUD
2011-04-13 20:28       ` Simon Glass
2011-04-13 21:05       ` Mike Frysinger
2011-04-14  5:01         ` Albert ARIBAUD
2011-04-13 23:30       ` Mike Frysinger
2011-04-14  5:58         ` Albert ARIBAUD
2011-04-14  6:12           ` Mike Frysinger
2011-04-14  6:51             ` Albert ARIBAUD
2011-04-15  7:56               ` Mike Frysinger
2011-04-15  8:13                 ` Albert ARIBAUD
2011-04-15  8:25                   ` Mike Frysinger
2011-04-15  9:34                     ` Albert ARIBAUD
2011-04-13  0:46 ` [U-Boot] [PATCH v2 3/5] Add documentation for USB Host Networking Simon Glass
2011-04-13  0:46 ` [U-Boot] [PATCH v2 4/5] Put common autoload code into AutoLoad() function Simon Glass
2011-04-13  0:46 ` [U-Boot] [PATCH v2 5/5] Allow tftp server to be different from bootp/dhcp server Simon Glass
2011-04-13  3:44 ` [U-Boot] [PATCH v2 1/5] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter Mike Frysinger
2011-04-13 18:47   ` Simon Glass
2011-04-13 19:45     ` Wolfgang Denk [this message]
2011-04-13 21:13       ` Simon Glass
2011-04-13 21:21         ` Simon Glass
2011-04-13 21:43           ` Simon Glass
2011-04-13 21:50           ` Wolfgang Denk
2011-04-13 21:08     ` Mike Frysinger
2011-04-13 22:31       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110413194518.546CBCF@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox