From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Wed, 13 Apr 2011 21:45:18 +0200
Subject: [U-Boot] [PATCH v2 1/5] Add support for SMSC95XX USB 2.0
	10/100MBit Ethernet Adapter
In-Reply-To: <BANLkTinacFQ=1xA4PTgZKi5ON9AGG7-Jwg@mail.gmail.com>
References: <1302655572-31544-1-git-send-email-sjg@chromium.org>
	<201104122344.43815.vapier@gentoo.org>
	<BANLkTinacFQ=1xA4PTgZKi5ON9AGG7-Jwg@mail.gmail.com>
Message-ID: <20110413194518.546CBCF@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Simon Glass,

In message <BANLkTinacFQ=1xA4PTgZKi5ON9AGG7-Jwg@mail.gmail.com> you wrote:
>
> >> +static void smsc95xx_halt(struct eth_device *eth)
> >> +{
> >> +     debug("** %s()\n", __func__);
> >> +}
> >
> > is this right ?  shouldnt you be halting something ?
> 
> I could do, but halting is not in the driver at present. Do you think
> it is important?

Yes, it is important to shut down devices.  Especially with USB
devices.

BTW: can you *please* fix your mail addresses?
It's not "Remy Bohmerl <inux@bohmer.net>"
but "Remy Bohmer <linux@bohmer.net>" instead.  Don't you get tons of
bounce messages?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every living thing wants to survive.
	-- Spock, "The Ultimate Computer", stardate 4731.3