public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cfi_flash: Fix CONFIG_SYS_FLASH_AUTOPROTECT_LIST usage
Date: Wed, 13 Apr 2011 21:50:40 +0200	[thread overview]
Message-ID: <20110413195040.E322ECF@gemini.denx.de> (raw)
In-Reply-To: <1302713216-23363-1-git-send-email-ptyser@xes-inc.com>

Dear Peter Tyser,

In message <1302713216-23363-1-git-send-email-ptyser@xes-inc.com> you wrote:
> Commit 6ee1416e8184b4d9ebe6087d396a60bcecf3551c (mtd, cfi: introduce
> void flash_protect_default(void)) introduced a bug which resulted in
> boards that define CONFIG_SYS_FLASH_AUTOPROTECT_LIST not compiling with
> the the following errors and warning:
>   ptyser at petert u-boot $ make -s xpedite520x
>   Configuring for xpedite520x board...
>   cfi_flash.c: In function 'flash_protect_default':
>   cfi_flash.c:2118: error: 'i' undeclared (first use in this function)
>   cfi_flash.c:2118: error: (Each undeclared identifier is reported only once
>   cfi_flash.c:2118: error: for each function it appears in.)
>   cfi_flash.c:2118: error: 'apl' undeclared (first use in this function)
>   cfi_flash.c:2118: error: invalid application of 'sizeof' to incomplete type 'struct apl_s'
>   cfi_flash.c: In function 'flash_init':
>   cfi_flash.c:2137: warning: unused variable 'apl'
> 
> Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> Reported-by: Kumar Gala <galak@kernel.crashing.org>
> Cc: Heiko Schocher <hs@denx.de>
> ---
> Thanks for noticing this Kumar.
> 
>  drivers/mtd/cfi_flash.c |   14 ++++++++------
>  1 files changed, 8 insertions(+), 6 deletions(-)

Appled, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The shortest unit of time in the multiverse is the News York  Second,
defined  as  the  period  of  time between the traffic lights turning
green and the cab behind you honking.
                                - Terry Pratchett, _Lords and Ladies_

      reply	other threads:[~2011-04-13 19:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-13 16:46 [U-Boot] [PATCH] cfi_flash: Fix CONFIG_SYS_FLASH_AUTOPROTECT_LIST usage Peter Tyser
2011-04-13 19:50 ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110413195040.E322ECF@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox