From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/9] cmd_sf: add handler for +len arg for erase command
Date: Fri, 15 Apr 2011 03:49:22 -0400 [thread overview]
Message-ID: <201104150349.23292.vapier@gentoo.org> (raw)
In-Reply-To: <4DA75E94.2020202@RuggedCom.com>
On Thursday, April 14, 2011 16:52:36 Richard Retanubun wrote:
> On 04/12/11 02:35, Mike Frysinger wrote:
> > This patch adds [+]len handler for the erase command that will
> > automatically round up the requested erase length to the flash's
> > sector_size.
> > ---
> > Richard: I noticed some issues in your original patch, so please try
> > this one instead and see if it still works for you.
>
> Code looks okay. I won't have time to test for a while. Feel free to
> mainline if it works for you if it makes problems for me, I'll figure it
> out and poke you then.
ive already pushed it ;)
mainly the thing i noticed was that the boundary cases werent working as
expected. e.g. if the sector size was 0x10000, doing +0x10000 would round up
to 0x20000.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110415/18c4d755/attachment.pgp
next prev parent reply other threads:[~2011-04-15 7:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 6:35 [U-Boot] [PATCH 0/9] SPI Flash updates for 2011.06 Mike Frysinger
2011-04-12 6:35 ` [U-Boot] [PATCH 1/9] sf: punt unused spi_flash_region struct Mike Frysinger
2011-04-12 6:35 ` [U-Boot] [PATCH 2/9] sf: atmel: undo unification of status polling Mike Frysinger
2011-04-12 6:35 ` [U-Boot] [PATCH 3/9] sf: add struct spi_flash.sector_size parameter Mike Frysinger
2011-04-12 6:35 ` [U-Boot] [PATCH 4/9] sf: sst: setup read func Mike Frysinger
2011-04-12 6:35 ` [U-Boot] [PATCH 5/9] sf: localize erase funcs Mike Frysinger
2011-04-12 6:35 ` [U-Boot] [PATCH 6/9] cmd_sf: add handler for +len arg for erase command Mike Frysinger
2011-04-14 20:52 ` Richard Retanubun
2011-04-15 7:49 ` Mike Frysinger [this message]
2011-04-12 6:35 ` [U-Boot] [PATCH 7/9] sf: use print_size() for sector_size output Mike Frysinger
2011-04-12 6:35 ` [U-Boot] [PATCH 8/9] cmd_sf: drop device status message when probing Mike Frysinger
2011-04-12 6:35 ` [U-Boot] [PATCH 9/9] cmd_sf: use cmd_usage() in more places Mike Frysinger
2011-04-13 19:28 ` [U-Boot] [PATCH 7/6] sf: sst: add support for SST25VF064C Mike Frysinger
2011-04-13 19:40 ` [U-Boot] Pull request u-boot-blackfin.git (sf branch) Mike Frysinger
2011-04-13 20:12 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104150349.23292.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox