From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch
Date: Fri, 15 Apr 2011 04:53:20 -0400 [thread overview]
Message-ID: <201104150453.21441.vapier@gentoo.org> (raw)
In-Reply-To: <BANLkTinNx7y5adWRjM15snfuAJV4eTaRcg@mail.gmail.com>
On Friday, April 15, 2011 04:25:58 Macpaul Lin wrote:
> 2011/4/15 Mike Frysinger:
> > On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote:
> >> #if !defined(CONFIG_ENV_IS_IN_EEPROM) && \
> >> - !defined(CONFIG_ENV_IS_IN_FLASH) && \
> >> + !defined(CONFIG_ENV_IS_IN_FLASH) && \
> >
> > not sure this one hunk is desirable, but the rest are fine
> > -mike
>
> Do you mean the replacement with space to ident?
>
> According to the 2.6.38.1's checkpatch, it reported:
> WARNING: please, no spaces at the start of a line
this particular check has already been posted upstream as generally causing
more harm than good. but getting checkpatch fixed often feels glacial.
up to Wolfgang how he feels about ifdef indentation
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110415/a00ad3df/attachment.pgp
next prev parent reply other threads:[~2011-04-15 8:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 7:02 [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch Macpaul Lin
2011-04-15 8:00 ` Mike Frysinger
2011-04-15 8:25 ` Macpaul Lin
2011-04-15 8:53 ` Mike Frysinger [this message]
2011-04-15 8:57 ` Macpaul Lin
2011-04-15 10:09 ` Wolfgang Denk
2011-04-15 10:18 ` Mike Frysinger
2011-04-16 6:18 ` Macpaul Lin
2011-04-16 6:35 ` Albert ARIBAUD
2011-04-16 6:22 ` Albert ARIBAUD
2011-04-16 7:07 ` Graeme Russ
2011-04-16 11:17 ` Macpaul Lin
2011-04-16 12:55 ` Albert ARIBAUD
2011-04-25 8:55 ` [U-Boot] [PATCH v2] " Macpaul Lin
2011-04-27 10:11 ` Detlev Zundel
2011-04-27 10:53 ` Macpaul Lin
2011-04-27 2:16 ` [U-Boot] [PATCH v3] " Macpaul Lin
2011-04-27 14:44 ` Detlev Zundel
2011-04-27 14:49 ` Macpaul Lin
2011-04-30 20:27 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104150453.21441.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox