public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alessandro Rubini <rubini-list@gnudd.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Question about relocation
Date: Sun, 17 Apr 2011 21:30:39 +0200	[thread overview]
Message-ID: <20110417193039.GA29460@mail.gnudd.com> (raw)
In-Reply-To: <4DAB301B.3030201@aribaud.net>

>> Ori, simply, end-to-beginning when moving up. Or always
>> end-to-beginning since we are expected to always move up (upper than
>> the target address it can't run).
 
> Since the 'issue' is caused by the code assuming one direction, I'd
> prefer it not to assume the other now; I prefer choosing
> end-to-beginning if target is dest than source, beginning-to-end otherwise.

but the calculation is done to move to end of ram, so dest is always
higher than source. 

> Actually no, copying and fixing is not done in a single run. There is
> the copying of the text+data+const area, then the fixing which runs
> through the relocation table area; they are different.

Yes, that's what I meant. It's not a memcpy, you also use the data
after the copy so any overlap is an issue, indepentend of the order
of copying.
 
>> Or, easier: if we are already high enough to overlap, don't relocate
>> at all.  If it's acceptable, I'll patch for taht.

> But then comes the question of how enough is "high enough". :)

If there's no overlap, you can relocate. If the areas overal, you keep
the current address which also is "high enough".

If you ack (even offlist) I'll submit a patch tomorrow (monday)
/alessandro

  reply	other threads:[~2011-04-17 19:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-17  1:19 [U-Boot] Question about relocation Alessandro Rubini
2011-04-17 17:04 ` Albert ARIBAUD
2011-04-17 17:57   ` Alessandro Rubini
2011-04-17 18:23     ` Albert ARIBAUD
2011-04-17 19:30       ` Alessandro Rubini [this message]
2011-04-17 19:47         ` Albert ARIBAUD
2011-04-18  9:16           ` Alessandro Rubini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110417193039.GA29460@mail.gnudd.com \
    --to=rubini-list@gnudd.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox