From: Eric Cooper <ecc@cmu.edu>
To: u-boot@lists.denx.de
Subject: [U-Boot] Policy for checkpatch usage?
Date: Thu, 21 Apr 2011 11:04:07 -0400 [thread overview]
Message-ID: <20110421150407.GC3680@localhost> (raw)
In-Reply-To: <5.2.0.9.1.20110421165402.04b12a50@localhost>
On Thu, Apr 21, 2011 at 04:56:36PM +0200, Fabian Cenedese wrote:
> Is that even possible? The cosmetic patch itself will be surrounded
> by context lines which may fire up a warning. So these lines need
> to be changed as well to satisy checkpatch. But this new patch
> will again include several context lines... until you have to fix up the
> whole file. Or did I misunderstand?
What's wrong with (cosmetically) fixing all the files that a patch
touches? That way the project gets incremental cleanup of the code
base as it evolves.
(It would be easy to automate a check for whitespace-only patches to
ease the job of the custodians. Line-breaking and other style changes
might still require eyeballing.)
--
Eric Cooper e c c @ c m u . e d u
next prev parent reply other threads:[~2011-04-21 15:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 9:24 [U-Boot] Policy for checkpatch usage? Detlev Zundel
2011-04-20 10:15 ` Graeme Russ
2011-04-20 12:43 ` Graeme Russ
2011-04-20 13:40 ` Detlev Zundel
2011-04-20 13:38 ` Detlev Zundel
2011-04-20 16:51 ` Scott Wood
2011-04-21 0:09 ` Graeme Russ
2011-04-21 5:18 ` Wolfgang Denk
2011-04-21 14:24 ` Detlev Zundel
2011-04-21 14:29 ` Detlev Zundel
2011-04-21 14:49 ` Eric Cooper
2011-04-21 14:56 ` Fabian Cenedese
2011-04-21 15:04 ` Eric Cooper [this message]
2011-04-21 15:37 ` Detlev Zundel
2011-04-21 15:19 ` Detlev Zundel
2011-04-21 15:46 ` Detlev Zundel
2011-04-23 15:29 ` Andreas Pretzsch
2011-04-27 9:07 ` Detlev Zundel
2011-04-21 16:10 ` Scott Wood
2011-04-22 0:43 ` Graeme Russ
2011-04-22 6:18 ` Albert ARIBAUD
2011-04-22 10:56 ` Graeme Russ
2011-04-22 8:54 ` Wolfgang Denk
2011-04-22 10:52 ` Graeme Russ
2011-04-22 12:46 ` Wolfgang Denk
2011-04-25 5:37 ` Graeme Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110421150407.GC3680@localhost \
--to=ecc@cmu.edu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox