public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [v2] powerpc/85xx: fix compatible property for the L2 cache node
Date: Fri, 29 Apr 2011 22:33:55 +0200	[thread overview]
Message-ID: <20110429203355.C9343D5270C@gemini.denx.de> (raw)
In-Reply-To: <8188C4AC-9553-4F2D-9370-9416D63AF6A7@freescale.com>

Dear Kumar Gala,

In message <8188C4AC-9553-4F2D-9370-9416D63AF6A7@freescale.com> you wrote:
> 
> On Apr 29, 2011, at 9:58 AM, Timur Tabi wrote:
> 
> > The compatible property for the L2 cache node (on 85xx systems that don't
> > have a CPC) was using a value for the property length that did not match
> > the actual length of the property.
> > 
> > Signed-off-by: Timur Tabi <timur@freescale.com>
> > ---
> > arch/powerpc/cpu/mpc85xx/fdt.c |   13 +++++++------
> > 1 files changed, 7 insertions(+), 6 deletions(-)
> 
> applied to 85xx

Kumar, don't you think that 32 minutes of review time is way too long
for such a patch??  Maybe we should stop doing code reviews, and just
accept all crap that gets posted here.

Hey, we could automate this and have lots of free time instead.

NAK!!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Ernest asks Frank how long he has been working for the company.
        "Ever since they threatened to fire me."

  reply	other threads:[~2011-04-29 20:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29 14:58 [U-Boot] [PATCH] [v2] powerpc/85xx: fix compatible property for the L2 cache node Timur Tabi
2011-04-29 15:31 ` Kumar Gala
2011-04-29 20:33   ` Wolfgang Denk [this message]
2011-04-29 20:36     ` Kumar Gala
2011-04-29 20:40       ` Wolfgang Denk
2011-04-29 20:30 ` Wolfgang Denk
2011-04-29 20:44   ` Scott Wood
2011-04-29 20:55     ` Wolfgang Denk
2011-04-29 21:01       ` Timur Tabi
2011-04-29 22:16         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110429203355.C9343D5270C@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox