public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mpc83xx fdt: do not adjust clock frequency of external UARTs
Date: Mon, 2 May 2011 11:33:52 -0500	[thread overview]
Message-ID: <20110502113352.b8ca04cd.kim.phillips@freescale.com> (raw)
In-Reply-To: <1302870633-14522-1-git-send-email-d.mueller@elsoft.ch>

On Fri, 15 Apr 2011 14:30:33 +0200
David M?ller <d.mueller@elsoft.ch> wrote:

> The current 83xx FDT implementation adjusts the clock frequency of all
> 16550 UARTs found in the device tree. This behaviour is ok for the UARTs
> which are part of the SoC, but wrong for any additional external UART.
> 
> Signed-off-by: David M?ller <d.mueller@elsoft.ch>
> 
> ---
>  arch/powerpc/cpu/mpc83xx/fdt.c |   27 +++++++++++++++++++++++++--
>  1 files changed, 25 insertions(+), 2 deletions(-)

(a) this is not an mpc83xx-specific issue

(b) the fdt code here should instead be modified to only adjust clock
properties on UART nodes contained within the SoC node, not the entire
fdt.

Any UARTs not a part of the SoC should get their clocks updated in
board/ code (or, as in this case, set manually in the device tree).

Kim

      parent reply	other threads:[~2011-05-02 16:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15 12:30 [U-Boot] [PATCH] mpc83xx fdt: do not adjust clock frequency of external UARTs David Müller
2011-04-15 17:44 ` Timur Tabi
2011-04-16  5:30   ` "David Müller (ELSOFT AG)"
2011-04-16 12:41     ` Tabi Timur-B04825
2011-04-18  6:58       ` "David Müller (ELSOFT AG)"
2011-05-02 16:33 ` Kim Phillips [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110502113352.b8ca04cd.kim.phillips@freescale.com \
    --to=kim.phillips@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox