public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/2] GPIO: Tegra2: add GPIO driver for Tegra2
Date: Mon, 2 May 2011 19:15:00 -0400	[thread overview]
Message-ID: <201105021915.01837.vapier@gentoo.org> (raw)
In-Reply-To: <1304376348-26403-2-git-send-email-twarren@nvidia.com>

On Monday, May 02, 2011 18:45:47 Tom Warren wrote:
> +U_BOOT_CMD(
> +	gpio,	5,	1,	do_gpio,

looks to me like you're duplicating a lot of code that already exists in 
common/cmd_gpio.c
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110502/8932faa2/attachment.pgp 

  reply	other threads:[~2011-05-02 23:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-02 22:45 [U-Boot] [PATCH V2 0/2] GPIO: Tegra2: add GPIO driver for Tegra2 Tom Warren
2011-05-02 22:45 ` [U-Boot] [PATCH V2 1/2] " Tom Warren
2011-05-02 23:15   ` Mike Frysinger [this message]
2011-05-02 23:16     ` Tom Warren
2011-05-02 22:45 ` [U-Boot] [PATCH V2 2/2] arm: Tegra2: GPIO: enable GPIO for Tegra2 boards Tom Warren
  -- strict thread matches above, loose matches on Subject: below --
2011-05-03 16:49 [U-Boot] [PATCH V2 1/2] GPIO: Tegra2: add GPIO driver for Tegra2 Michael Walle
2011-05-03 19:29 ` Mike Frysinger
2011-06-02 20:00   ` Tom Warren
2011-06-02 20:56     ` Wolfgang Denk
2011-06-02 21:30       ` Tom Warren
2011-06-02 21:34         ` Wolfgang Denk
2011-06-02 21:55           ` Tom Warren
2011-06-03  4:36             ` Wolfgang Denk
2011-06-03  4:55             ` Mike Frysinger
2011-06-03  4:53         ` Mike Frysinger
2011-06-03 16:01           ` Tom Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105021915.01837.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox