public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] PPC405EX CHIP_21 erratum
Date: Tue, 3 May 2011 15:07:40 +0200	[thread overview]
Message-ID: <201105031507.41274.sr@denx.de> (raw)
In-Reply-To: <4DBF25DA.7040806@harris.com>

On Monday 02 May 2011 23:44:58 Steven A. Falco wrote:
> I have not been able to find a way to distinguish a power-up versus a
> reboot. So for now, I've implemented the AMCC bug fix more or less as
> written.  To do it right, we'd have to add entries in every U-Boot config
> file for the 405 EX/EXr to definitively specify the CPU type expected, and
> to put the list of allowed PVRs in the code.
> 
> This means that the PVR is essentially useless to distinguish between the
> EX and EXr, because we have seen one misbehaving EX report as an EXr!
> If the PVR had been garbage, we could maybe use it, but reporting "wrong
> yet legal" values makes it worthless.
> 
> All our boards use the EX, so we are able to live with this, but I realize
> it is not a solution for the larger community.  That is why I have not
> proposed a definitive patch.

I see. Thanks for the explanation.

IMHO, it would be best to provide a default list of PVR's that are 
allowed/correct for 405EX(r). And this list can be overridden by a board 
specific version (as needed in your case). Not sure how to handle this 
elegantly in assembler though.

We might move this to cpu_init_f(). This is the first C function called via 
start.S. It already handles similar issues for some 4xx SoC variants 
(reconfigure_pll()) which require a system reboot.

What do you think? Would you be able to prepare a patch with such a CHIP_21 
fix?

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  reply	other threads:[~2011-05-03 13:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4DBF1F33.4040101@harris.com>
2011-05-02 21:44 ` [U-Boot] PPC405EX CHIP_21 erratum Steven A. Falco
2011-05-03 13:07   ` Stefan Roese [this message]
2011-05-03 16:59     ` [U-Boot] [PATCH v1] " Steven A. Falco
2011-05-04  8:03       ` Eibach, Dirk
2011-05-04  8:36       ` Stefan Roese
2011-05-04 14:26         ` Steven A. Falco
2011-04-29 16:54 [U-Boot] " Steven A. Falco
2011-05-02 11:50 ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105031507.41274.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox