From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nand_spl: nand_boot.c: Init nand_chip.options to 0
Date: Fri, 6 May 2011 15:12:18 +0200 [thread overview]
Message-ID: <201105061512.18820.sr@denx.de> (raw)
In-Reply-To: <20110504123029.41c610ed@schlenkerla.am.freescale.net>
On Wednesday 04 May 2011 19:30:29 Scott Wood wrote:
> > + nand_chip.options = 0;
> > board_nand_init(&nand_chip);
> >
> > if (nand_chip.select_chip)
>
> Maybe nand_chip should be made static so it goes in the BSS? This would
> avoid any other such problems, without adding any extra code to zero things
> out.
Yes, good idea. I tried it but it resulted in a bigger image instead of a
smaller one. I need to investigate further to see why this is the case...
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2011-05-06 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 9:44 [U-Boot] [PATCH] nand_spl: nand_boot.c: Init nand_chip.options to 0 Stefan Roese
2011-05-04 17:30 ` Scott Wood
2011-05-06 13:12 ` Stefan Roese [this message]
2011-05-13 16:16 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105061512.18820.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox