From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 6 May 2011 15:12:18 +0200 Subject: [U-Boot] [PATCH] nand_spl: nand_boot.c: Init nand_chip.options to 0 In-Reply-To: <20110504123029.41c610ed@schlenkerla.am.freescale.net> References: <1304502284-392-1-git-send-email-sr@denx.de> <20110504123029.41c610ed@schlenkerla.am.freescale.net> Message-ID: <201105061512.18820.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 04 May 2011 19:30:29 Scott Wood wrote: > > + nand_chip.options = 0; > > board_nand_init(&nand_chip); > > > > if (nand_chip.select_chip) > > Maybe nand_chip should be made static so it goes in the BSS? This would > avoid any other such problems, without adding any extra code to zero things > out. Yes, good idea. I tried it but it resulted in a bigger image instead of a smaller one. I need to investigate further to see why this is the case... Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de