From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] RFC: auto-generate ARM mach-types.h file from ARM machine database
Date: Mon, 9 May 2011 11:29:15 -0400 [thread overview]
Message-ID: <201105091129.16517.vapier@gentoo.org> (raw)
In-Reply-To: <4DC5259C.7040208@discworld.dascon.de>
On Saturday, May 07, 2011 06:57:32 Michael Schwingen wrote:
> mach-types.h needs to be built before autoconf.mk can be generated, and
> the rules for autoconf.mk are in the top-level Makefile.
>
> If I put rules in arch/arm/config.mk, then the first of these rules
> becomes the default rule which is executed in subdir makes (like "make
> -C arch"), which breaks compilation completely, since config.mk is
> included before the rules are defined in the subdir Makefiles.
>
> It seems the current scheme allows only variable definitions in
> config.mk files, which is not sufficient here.
>
> rules.mk would be fine, however, there is no provision to include rules
> from lower directories, since all the building in subdirectories is
> handled by recursively calling make (this is one of the problems that
> arise by recursively calling make for each directory, but that is a
> different topic).
>
> Any ideas? Using the current Makefile structure, I see no other solution
> than defining the mach-types.h generation rules in the toplevel Makefile.
do you need the mach-types file for anything else ? if not, dont keep that in
git, keep the generated header.
> > also, dont hardcode full paths to things. there's no reason for it.
>
> Which of these can be omitted?
look for "/bin/" or "/sbin/". if your patch contains those, it is wrong.
> > might want to add an "update-mach-types" target so people can type
> > `make update-mach-types` and it'll automatically wget the right file
> > to the right place ...
>
> Good idea.
> I agree with Wolfgang that this is intended to be used by the maintainer
> mainly, so the mach-types file should be included in the source so that
> a normal user does not need to download the file.
i didnt suggest this in the first place
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110509/22259402/attachment.pgp
next prev parent reply other threads:[~2011-05-09 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 21:48 [U-Boot] RFC: auto-generate ARM mach-types.h file from ARM machine database Michael Schwingen
2011-05-06 5:09 ` Mike Frysinger
2011-05-07 10:57 ` Michael Schwingen
2011-05-09 5:37 ` Wolfgang Denk
2011-05-09 6:32 ` Michael Schwingen
2011-05-09 15:29 ` Mike Frysinger [this message]
2011-05-09 15:54 ` Michael Schwingen
2011-05-09 16:16 ` Mike Frysinger
2011-05-10 21:50 ` Albert ARIBAUD
2011-05-06 10:14 ` Wolfgang Denk
2011-05-07 10:58 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105091129.16517.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox