public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] post: new parallel nor flash test
Date: Tue, 10 May 2011 23:59:42 +0200	[thread overview]
Message-ID: <20110510215942.18554D6F237@gemini.denx.de> (raw)
In-Reply-To: <201105101711.07625.vapier@gentoo.org>

Dear Mike Frysinger,

In message <201105101711.07625.vapier@gentoo.org> you wrote:
>
> > > This adds a simple parallel nor flash test to automatically verify
> > > erasing/writing/reading of sectors.  The code is based on existing
> > > Blackfin tests but generalized for everyone to use.
> > 
> > What exactly does the "parallel" in "parallel nor flash test" mean?
> 
> how it is connected to the processor

Are there any other types of NOR flashes?  I mean, I have never heard
anybody use this term before.  Maybe we can just omit it - I find it
more confusing than helpful.

> > > +	unsigned char *ret = (void *)CONFIG_SYS_SDRAM_BASE;
> > 
> > This will not work on many systems.  For example, on PPC you will
> > overwrite the exception vectors in low memory, thus crashing the
> > system.
> 
> this is how the default memory post test works.  it writes all memory from
> CONFIG_SYS_SDRAM_BASE to CONFIG_SYS_SDRAM_BASE+MIN(1GiB,bd->memsize).  so how 
> does this work on ppc systems ?

The RAM test runs before relocation to RAM, i. e. whenRAM is still not
used by anything.

> i didnt think calling malloc() would be OK since i need enough memory to hold 
> one sector ...

Just grabbing a random address in RAM is certainly not a proper way
to allocate I/O buffers.  If you need them, and if your code design
makes it even necessary to pass these buffers around (so you can not
just put them on the stack which is what I would try to do) you have
to use malloc().

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The only way to learn a new programming language is by  writing  pro-
grams in it.                                        - Brian Kernighan

  reply	other threads:[~2011-05-10 21:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-10 20:08 [U-Boot] [PATCH] post: new parallel nor flash test Mike Frysinger
2011-05-10 20:17 ` Wolfgang Denk
2011-05-10 21:11   ` Mike Frysinger
2011-05-10 21:59     ` Wolfgang Denk [this message]
2011-05-10 22:46       ` Mike Frysinger
2011-05-10 23:35 ` [U-Boot] [PATCH v2] post: new " Mike Frysinger
2011-07-26 14:50   ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2012-02-01  7:47 [U-Boot] [PATCH] post: new parallel " Vaibhav Kothari
2012-02-01 16:59 ` Mike Frysinger
2013-05-18  6:40 Mathieu Clavette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110510215942.18554D6F237@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox