From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] post: add gpio hotkey support
Date: Thu, 12 May 2011 11:08:25 -0400 [thread overview]
Message-ID: <201105121108.34929.vapier@gentoo.org> (raw)
In-Reply-To: <4DCBD6FC.9020101@mvista.com>
On Thursday, May 12, 2011 08:47:56 Sergei Shtylyov wrote:
> On 11-05-2011 18:54, Mike Frysinger wrote:
> >>> int __post_hotkeys_pressed(void)
> >>> {
> >>> +#ifdef CONFIG_SYS_POST_HOTKEYS_GPIO
> >>> + return ret;
> >>> +#endif
> >>>
> >> You surely meant #else here?
> >>>
> >>> return 0; /* No hotkeys supported */
> >
> > not really what i was going for. it's fine either way though.
>
> I don't think 2 returns in a row is fine...
if there were no CPP here, then obviously you'd be right. but there is, and i
dont see much point now in adding a little more wrapping. gcc doesnt warn
about it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110512/d9f86960/attachment.pgp
next prev parent reply other threads:[~2011-05-12 15:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 17:01 [U-Boot] [PATCH] post: add gpio hotkey support Mike Frysinger
2011-05-11 11:42 ` Sergei Shtylyov
2011-05-11 14:54 ` Mike Frysinger
2011-05-12 12:47 ` Sergei Shtylyov
2011-05-12 15:08 ` Mike Frysinger [this message]
2011-07-26 14:47 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105121108.34929.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox