public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Simon Guinot <simon@sequanux.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATH v7 1/2] netconsole: remove `serverip' check
Date: Thu, 12 May 2011 11:55:21 +0000	[thread overview]
Message-ID: <20110512115521.GD6693@kw.sim.vm.gnt> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19FAC9645F@SC-VEXCH4.marvell.com>

Hi Prafulla,

On Thu, May 12, 2011 at 03:17:24AM -0700, Prafulla Wadaskar wrote:
> 
> 
> > -----Original Message-----
> > From: Simon Guinot [mailto:simon.guinot at sequanux.org]
> > Sent: Thursday, May 12, 2011 3:19 PM
> > To: Prafulla Wadaskar
> > Cc: Albert ARIBAUD; u-boot at lists.denx.de; Simon Guinot
> > Subject: [PATH v7 1/2] netconsole: remove `serverip' check
> > 
> > This patch allows to enable the netconsole even if `serverip' is not
> > set.
> > 
> > Because netconsole use the environment variable `ncip' to configure the
> > destination IP, `serverip' don't need to be defined.
> > 
> > Signed-off-by: Simon Guinot <sguinot@lacie.com>
> > ---
> > Changes for v2:
> >   - restore NetOurIP check
> > 
> > Changes for v3:
> >   - add a "/* Fall through */" comment before the NETCONS case label
> > 
> > Changes for v4,5: none
> > 
> > Changes for v6:
> >   - enhance commit message
> > 
> > Changes for v7: none
> > 
> >  net/net.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> This patch looks to be independent.
> I don't have any comments for this.
> Should be applied to u-boot-net.git.

The patch itself is independent but the Network Space v2 board setup
rely on it. Without this patch, the netconsole is not usable and the
netconsole is needed to update the stock U-Boot.

IMHO, this two patches should go in the same tree, to avoid a breakage
situation.

Regards,

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110512/b3bfb004/attachment.pgp 

  reply	other threads:[~2011-05-12 11:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-12  9:48 [U-Boot] [PATH v7 0/2] Add support for LaCie NAS Network Space v2 Simon Guinot
2011-05-12  9:48 ` [U-Boot] [PATH v7 1/2] netconsole: remove `serverip' check Simon Guinot
2011-05-12 10:17   ` Prafulla Wadaskar
2011-05-12 11:55     ` Simon Guinot [this message]
2011-05-12 12:14       ` Prafulla Wadaskar
2011-05-12 16:16       ` Wolfgang Denk
2011-05-12 15:14     ` Mike Frysinger
2011-05-12 17:12   ` Wolfgang Denk
2011-05-13 11:52     ` Prafulla Wadaskar
2011-05-12  9:48 ` [U-Boot] [PATH v7 2/2] Add support for Network Space v2 Simon Guinot
2011-05-12 10:36   ` Prafulla Wadaskar
2011-05-12 11:47     ` Simon Guinot
2011-05-12 12:04       ` Prafulla Wadaskar
2011-05-12 16:15       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110512115521.GD6693@kw.sim.vm.gnt \
    --to=simon@sequanux.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox