public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] PPC405EX CHIP_21 erratum
Date: Thu, 12 May 2011 16:14:18 +0200	[thread overview]
Message-ID: <201105121614.18767.sr@denx.de> (raw)
In-Reply-To: <4DC2AF63.5060008@harris.com>

On Thursday 05 May 2011 16:08:35 Steven A. Falco wrote:
> APM errata CHIP_21 for the 405EX/EXr (from the rev 1.09 document dated
> 4/27/11) states that rev D processors may wake up with the wrong feature
> set.  This patch implements the APM-proposed workaround.
> 
> To enable this patch for your board, add the appropriate define for your
> CPU to your board header file.  See kilauea.h for more information.  The
> following variants are supported:
> 
> #define CONFIG_SYS_4xx_CHIP_21_405EX_NO_SECURITY
> #define CONFIG_SYS_4xx_CHIP_21_405EX_SECURITY
> #define CONFIG_SYS_4xx_CHIP_21_405EXr_NO_SECURITY
> #define CONFIG_SYS_4xx_CHIP_21_405EXr_SECURITY
> 
> Please note that if you select the wrong define, your board will not
> boot, and JTAG will be required to recover.
> 
> Tested on custom boards using:
> 
> CONFIG_SYS_4xx_CHIP_21_405EX_NO_SECURITY  <sfalco@harris.com>
> CONFIG_SYS_4xx_CHIP_21_405EX_SECURITY     <eibach@gdsys.de>
> 
> Signed-off-by: Steve Falco <sfalco@harris.com>
> Acked-by: Dirk Eibach <eibach@gdsys.de>

checkpatch has some minor problems with your patch:

checkpatch.pl patches_misc/\[U-Boot\]\ \[PATCH\ v3\]\ PPC405EX\ CHIP_21\ 
erratum.mbox 
ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#122: FILE: arch/powerpc/cpu/ppc4xx/cpu_init.c:241:
+        * SDR0_ECID3[12:15] is different from PVR[28:31], then ? processor is
                                                                ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#124: FILE: arch/powerpc/cpu/ppc4xx/cpu_init.c:243:
+        * required).  else ? go to step 3.
                            ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#127: FILE: arch/powerpc/cpu/ppc4xx/cpu_init.c:246:
+        * SDR0_ECID3[10:11] matches its expected value, then ? continue
                                                              ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#128: FILE: arch/powerpc/cpu/ppc4xx/cpu_init.c:247:
+        * executing initialization code, no reset required.  else ? write
                                                                   ^

total: 4 errors, 0 warnings, 144 lines checked



No need to resend, I fixed this manually.

Applied to u-boot-ppc4xx/master. Thanks.
 
Best regards,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

      parent reply	other threads:[~2011-05-12 14:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-05 14:08 [U-Boot] [PATCH v3] PPC405EX CHIP_21 erratum Steven A. Falco
2011-05-12 13:52 ` Steven A. Falco
2011-05-12 14:14 ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105121614.18767.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox