public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] memcpy/memmove: Do not copy to same address
Date: Tue, 24 May 2011 22:39:16 +0200	[thread overview]
Message-ID: <20110524203916.8CCB2CF5DBF@gemini.denx.de> (raw)
In-Reply-To: <20110524143749.0b508c66@schlenkerla.am.freescale.net>

Dear Scott Wood,

In message <20110524143749.0b508c66@schlenkerla.am.freescale.net> you wrote:
>
> Might want to pass -fno-delete-null-pointer-checks...

Thanks for pointing out.

> As for memcpy/memmove, if in U-Boot it's to be legal to pass overlapping
> regions to memcpy(), why have separate implementations (not to mention
> bcopy...)?

Define "legal"?  Legal as in "everything that is not explicitly
forbidden"?  Legal as in "any code that does not exwecute the HCF
instruction"?

The man page says: "The memory areas should not overlap. Use
memmove(3) if the memory areas do overlap."  I have nothing to add
here.

As for the different implementations: well, U-Boot imported tons of
code from different sources, using different interfaces and library
functions.  Where needed, the missing library functions got added.

Cleanup patches are always welcome.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Hegel was right when he said that we learn from history that man  can
never learn anything from history.              - George Bernard Shaw

  reply	other threads:[~2011-05-24 20:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12  6:58 [U-Boot] [PATCH] Do not copy to same address Matthias Weisser
2011-04-12  7:05 ` Mike Frysinger
2011-04-12  7:16   ` Matthias Weißer
2011-04-12  7:06 ` Albert ARIBAUD
2011-04-12  7:13   ` Matthias Weißer
2011-04-12  7:27     ` Albert ARIBAUD
2011-04-12  7:49       ` Matthias Weißer
2011-04-14  6:28         ` Albert ARIBAUD
2011-05-23  9:03 ` [U-Boot] [PATCH V2] memcpy/memmove: " Matthias Weisser
2011-05-23 21:07   ` Alexander Holler
2011-05-23 21:55     ` Wolfgang Denk
2011-05-23 22:12       ` Alexander Holler
2011-05-23 22:22         ` Wolfgang Denk
2011-05-23 22:38           ` Alexander Holler
2011-05-24  3:47             ` Mike Frysinger
2011-05-24 13:03               ` Alexander Holler
2011-05-24 19:37           ` Scott Wood
2011-05-24 20:39             ` Wolfgang Denk [this message]
2011-06-14  6:18   ` Matthias Weißer
2011-06-16 16:04     ` Matthias Weisser
2011-06-30  6:31     ` Matthias Weißer
2011-07-25 22:28   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110524203916.8CCB2CF5DBF@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox