From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] post, arm, memorytest: add support for arm based boards
Date: Wed, 1 Jun 2011 09:51:40 -0400 [thread overview]
Message-ID: <201106010951.42345.vapier@gentoo.org> (raw)
In-Reply-To: <4DE5E226.3090008@denx.de>
On Wednesday, June 01, 2011 02:54:30 Heiko Schocher wrote:
> Wolfgang Denk wrote:
> > Heiko Schocher wrote:
> >> --- a/post/drivers/memory.c
> >> +++ b/post/drivers/memory.c
> >> @@ -455,10 +455,30 @@ static int memory_post_tests (unsigned long start,
> >> unsigned long size)
> >>
> >> __attribute__((weak))
> >> int arch_memory_test_prepare(u32 *vstart, u32 *size, phys_addr_t
> >> *phys_offset) {
> >>
> >> +#if defined(CONFIG_ARM)
> >
> > This is a weak function, so there should be no need to have #ifdef's
> > in there.
> >
> > Just define your own code as you need it.
>
> Yes (I did this for my case, as I use it in nand_spl code,
> and therefore I need a "own" function, because there I have no
> bd ) ... but, for arm there is no bd->bi_memsize! ... so this
> file fails compiling. Independent, if it gets replaced by
> another function.
so add bi_memsize to arm ? it's the only arch that lacks it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110601/f6f6a2f3/attachment.pgp
next prev parent reply other threads:[~2011-06-01 13:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 6:24 [U-Boot] [PATCH] post, memorytest: fix if vstart is not = 0x0 Heiko Schocher
2011-06-01 6:24 ` [U-Boot] [PATCH] post, arm, memorytest: add support for arm based boards Heiko Schocher
2011-06-01 6:37 ` Wolfgang Denk
2011-06-01 6:54 ` Heiko Schocher
2011-06-01 13:51 ` Mike Frysinger [this message]
2011-06-02 5:53 ` Heiko Schocher
2011-06-02 12:40 ` Wolfgang Denk
2011-06-02 15:08 ` Mike Frysinger
2011-06-03 5:39 ` Heiko Schocher
2011-06-03 6:30 ` Wolfgang Denk
2011-06-01 6:24 ` [U-Boot] [PATCH] post, memory test: add memory_post_test() to include file Heiko Schocher
2011-07-25 21:43 ` Wolfgang Denk
2011-07-26 8:26 ` Wolfgang Denk
2011-07-26 11:57 ` Wolfgang Denk
2011-07-26 16:41 ` Heiko Schocher
2011-07-27 6:31 ` [U-Boot] [PATCH v2] " Heiko Schocher
2011-07-28 20:39 ` Wolfgang Denk
2011-07-27 21:37 ` [U-Boot] [PATCH] post, memorytest: fix if vstart is not = 0x0 Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106010951.42345.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox