public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx31: Improve the handling of unidentified silicon version
Date: Wed, 15 Jun 2011 14:47:16 +0200	[thread overview]
Message-ID: <20110615124716.45416138EF1F@gemini.denx.de> (raw)
In-Reply-To: <4DF8A2DE.3040501@denx.de>

Dear Stefano Babic,

In message <4DF8A2DE.3040501@denx.de> you wrote:
>
> > Reading rev 2.0 on Felix=B4s case is misleading IMHO as we tend to
> > think that we have a TO2.0 silicon on his board even though we get a
> > "unknown" string.
> 
> Ok, so only reading the code we can know that version number + "unknown"
> give us the value of the srev register. We can explicitely expand the
> output to make things clearer.

Given that this is an exotic error case that happens only on a very
small number of chips that are actually not supposed to exist at all,
I think this is not worth the effort.

The "unknown" is warning enough, and anybody who needs to know more
details can see theremaining details easily from the code.

> Agree with your proposal.

No.  We should not add code that is almost never ever useful anywhere,
just to make this message more verbose.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Was hei?t Windows auf Indianisch? - "Wei?er  Mann,  der  auf  Sanduhr
wartet!"

  reply	other threads:[~2011-06-15 12:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 16:31 [U-Boot] [PATCH] mx31: Improve the handling of unidentified silicon version Fabio Estevam
2011-06-14 22:46 ` Graeme Russ
2011-06-15  5:28 ` Wolfgang Denk
2011-06-15  5:29 ` Stefano Babic
2011-06-15 11:50   ` Fabio Estevam
2011-06-15 12:08     ` Graeme Russ
2011-06-15 12:17       ` Fabio Estevam
2011-06-15 12:12     ` Wolfgang Denk
2011-06-15 12:33       ` Graeme Russ
2011-06-15 12:49         ` Wolfgang Denk
2011-06-15 13:00           ` Graeme Russ
2011-06-15 12:17     ` Stefano Babic
2011-06-15 12:47       ` Wolfgang Denk [this message]
2011-06-15 13:02         ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110615124716.45416138EF1F@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox