From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tools: make it possible to build tools unconfigured
Date: Sat, 18 Jun 2011 15:03:09 -0400 [thread overview]
Message-ID: <201106181503.10550.vapier@gentoo.org> (raw)
In-Reply-To: <1308173853-20178-1-git-send-email-yanok@emcraft.com>
On Wednesday, June 15, 2011 17:37:33 Ilya Yanok wrote:
> Sometimes we want to build common tools without configuring for specific
> target. Currently top Makefile has some support for this but it doesn't
> work. This patch tries to fix this.
i think you'll need to split this up in logical sep changesets since you are
fixing different problems.
> Things changed:
> - config.mk disable 'ld script not found error' in case if we are
> building tools only.
i dont like copying & pasting the same logic in multiple places. this is how
code rots and bug fixes diverge.
considering LDSCRIPT/CONFIG_SYS_LDSCRIPT only get used by the top level u-boot
file, and only when the system is configured, i wonder if we shouldnt just rip
it out of config.mk and into the top level Makefile.
let's see what Scott thinks ...
> - Makefile mkimage relies on autogenerated version so we need to
> move $(VERSION_FILE) rule out of ifeq and make tools rule depend on it.
the VERSION_FILE changes look fine
> - tools/Makefile put common/env_embedded.o and envcrc.o to object list
> conditionally. This fixes errors during dependency generation.
pretty sure this breaks board builds. if the only thing this fixes is a
harmless warning when generating dependency files, then i say ignore it.
after all, this is how it has always worked in the past and no one really
cared.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110618/5b53f0b2/attachment.pgp
next prev parent reply other threads:[~2011-06-18 19:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 21:37 [U-Boot] [PATCH] tools: make it possible to build tools unconfigured Ilya Yanok
2011-06-18 19:03 ` Mike Frysinger [this message]
2011-06-18 20:11 ` Wolfgang Denk
2011-06-18 20:21 ` Mike Frysinger
2011-06-19 17:55 ` Ilya Yanok
2011-06-19 18:27 ` Mike Frysinger
2011-06-19 22:46 ` Ilya Yanok
2011-06-19 23:22 ` Mike Frysinger
2011-06-20 17:52 ` Scott Wood
2011-10-17 19:42 ` Wolfgang Denk
2011-10-17 20:24 ` Ilya Yanok
2011-10-17 20:35 ` Wolfgang Denk
2011-10-17 20:48 ` Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106181503.10550.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox