* [U-Boot] [Patch] Update filesize environment variable on ubifs_load
@ 2011-06-18 10:30 Rod Boyce
2011-06-29 8:41 ` Stefan Roese
0 siblings, 1 reply; 2+ messages in thread
From: Rod Boyce @ 2011-06-18 10:30 UTC (permalink / raw)
To: u-boot
Add functionality to update filesize environment variable when
ubifs_load is called to read a file from filesystem
Signed-off-by: Rod Boyce <uboot@teamboyce.co.uk>
------------------------------- fs/ubifs/ubifs.c
------------------------------
diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c
index 61f70b2..17097f2 100644
--- a/fs/ubifs/ubifs.c
+++ b/fs/ubifs/ubifs.c
@@ -686,6 +686,7 @@
int i;
int count;
int last_block_size = 0;
+ char buf[32];
c->ubi = ubi_open_volume(c->vi.ubi_num, c->vi.vol_id, UBI_READONLY);
/* ubifs_findfile will resolve symlinks, so we know that we get
@@ -716,6 +717,8 @@
count = (size + UBIFS_BLOCK_SIZE - 1) >> UBIFS_BLOCK_SHIFT;
printf("Loading file '%s' to addr 0x%08x with size %d (0x%08x)...\n",
filename, addr, size, size);
+ sprintf( buf, "%X", size );
+ setenv( "filesize", buf );
page.addr = (void *)addr;
page.index = 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [Patch] Update filesize environment variable on ubifs_load
2011-06-18 10:30 [U-Boot] [Patch] Update filesize environment variable on ubifs_load Rod Boyce
@ 2011-06-29 8:41 ` Stefan Roese
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Roese @ 2011-06-29 8:41 UTC (permalink / raw)
To: u-boot
Hi Rod,
On Saturday 18 June 2011 12:30:18 Rod Boyce wrote:
> Add functionality to update filesize environment variable when
> ubifs_load is called to read a file from filesystem
>
> Signed-off-by: Rod Boyce <uboot@teamboyce.co.uk>
> ------------------------------- fs/ubifs/ubifs.c
> ------------------------------
> diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c
> index 61f70b2..17097f2 100644
> --- a/fs/ubifs/ubifs.c
> +++ b/fs/ubifs/ubifs.c
> @@ -686,6 +686,7 @@
> int i;
> int count;
> int last_block_size = 0;
> + char buf[32];
>
> c->ubi = ubi_open_volume(c->vi.ubi_num, c->vi.vol_id, UBI_READONLY);
> /* ubifs_findfile will resolve symlinks, so we know that we get
> @@ -716,6 +717,8 @@
> count = (size + UBIFS_BLOCK_SIZE - 1) >> UBIFS_BLOCK_SHIFT;
> printf("Loading file '%s' to addr 0x%08x with size %d (0x%08x)...\n",
> filename, addr, size, size);
> + sprintf( buf, "%X", size );
> + setenv( "filesize", buf );
Again, patch does not apply (indentation seems broken). Please see my comments
in the last mail. And please don't add a space after "(" and before ")":
+ sprintf(buf, "%X", size);
+ setenv("filesize", buf);
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-29 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-18 10:30 [U-Boot] [Patch] Update filesize environment variable on ubifs_load Rod Boyce
2011-06-29 8:41 ` Stefan Roese
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox