From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] I2C: mxc_i2c rework
Date: Wed, 13 Jul 2011 20:31:16 +0200 [thread overview]
Message-ID: <20110713183116.58FEC17367E8@gemini.denx.de> (raw)
In-Reply-To: <1310578117-7687-1-git-send-email-marek.vasut@gmail.com>
Dear Marek Vasut,
In message <1310578117-7687-1-git-send-email-marek.vasut@gmail.com> you wrote:
> Rewrite the mxc_i2c driver.
> * This version is much closer to Linux implementation.
> * Fixes IPG_PERCLK being incorrectly used as clock source
> * Fixes behaviour of the driver on iMX51
> * Clean up coding style a bit ;-)
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
> drivers/i2c/mxc_i2c.c | 414 +++++++++++++++++++++++++++++++++----------------
> 1 files changed, 281 insertions(+), 133 deletions(-)
NAK.
You submitted a changed (?) version, but without marking this as such
in the subject, and without providing a changelog. Please see
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
And don't forget to add the necessary reference to the Linux code you
referred to.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The world is coming to an end -- save your buffers!
next prev parent reply other threads:[~2011-07-13 18:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 17:28 [U-Boot] [PATCH] I2C: mxc_i2c rework Marek Vasut
2011-07-13 18:31 ` Wolfgang Denk [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-13 9:53 Marek Vasut
2011-07-13 13:56 ` Stefano Babic
2011-07-13 17:12 ` Marek Vasut
2011-07-13 18:29 ` Wolfgang Denk
2011-07-13 18:32 ` Marek Vasut
2011-07-13 21:51 ` Marek Vasut
2011-07-14 8:58 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110713183116.58FEC17367E8@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox