From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] mkconfig: create CONFIG_ defines without relying on GNU extensions
Date: Wed, 20 Jul 2011 00:57:58 +0200 [thread overview]
Message-ID: <201107200057.58325.marek.vasut@gmail.com> (raw)
In-Reply-To: <1311108110-37409-3-git-send-email-jeroen@myspectrum.nl>
On Tuesday, July 19, 2011 10:41:49 PM Jeroen Hofstee wrote:
> Parsing of boards.cfg relies on sed GNU extensions and fails if sed
> doesn't support these. On FreeBSD this leads to the error:
>
> sed: 1: "/=/ {s/=/\t/;q } ; { s/ ...": extra characters at the end
> of q command
Does it still work on linux as well? Did you test? If so, I'm all for it being
merged, but just from a brief look, I see it'll be missing the TAB. Am I right?
>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> ---
> mkconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mkconfig b/mkconfig
> index 6ff533f..b9cfc94 100755
> --- a/mkconfig
> +++ b/mkconfig
> @@ -148,7 +148,7 @@ fi
> echo "/* Automatically generated - do not edit */" >>config.h
>
> for i in ${TARGETS} ; do
> - i="`echo ${i} | sed '/=/ {s/=/\t/;q } ; { s/$/\t1/ }'`"
> + i="`echo ${i} | sed -e '/=/!s/$/=1/' -e 's/=/ /'`"
> echo "#define CONFIG_${i}" >>config.h ;
> done
next prev parent reply other threads:[~2011-07-19 22:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 20:41 [U-Boot] [PATCH 0/3] improve build for UNIX like non GNU platforms Jeroen Hofstee
2011-07-19 20:41 ` [U-Boot] [PATCH 1/3] include/compiler.h: typedef ulong for FreeBSD Jeroen Hofstee
2011-07-28 19:17 ` Wolfgang Denk
2011-07-19 20:41 ` [U-Boot] [PATCH 2/3] mkconfig: create CONFIG_ defines without relying on GNU extensions Jeroen Hofstee
2011-07-19 21:03 ` Mike Frysinger
2011-07-19 21:28 ` Jeroen Hofstee
2011-07-19 21:38 ` Mike Frysinger
2011-07-19 22:05 ` Jeroen Hofstee
2011-07-19 22:57 ` Marek Vasut [this message]
2011-07-19 23:03 ` Mike Frysinger
2011-07-19 23:09 ` Jeroen Hofstee
2011-07-19 20:41 ` [U-Boot] [PATCH 3/3] rules.mk: replace GNU specific \w with POSIX equivalant Jeroen Hofstee
2011-07-28 19:18 ` Wolfgang Denk
2011-07-20 18:38 ` [U-Boot] [PATCH v2 0/3] improve build for UNIX like non GNU platforms Jeroen Hofstee
2011-07-20 18:38 ` [U-Boot] [PATCH v2 3/3] mkconfig: also create CONFIG defines with BSD sed Jeroen Hofstee
2011-07-20 20:08 ` Mike Frysinger
2011-07-28 19:18 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107200057.58325.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox