From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: designware: fix uninitialized phy_addr usage
Date: Mon, 25 Jul 2011 22:21:46 +0200 [thread overview]
Message-ID: <20110725202146.8622B138EED4@gemini.denx.de> (raw)
In-Reply-To: <1307027978-13418-2-git-send-email-vapier@gentoo.org>
Dear Mike Frysinger,
In message <1307027978-13418-2-git-send-email-vapier@gentoo.org> you wrote:
> When CONFIG_DW_SEARCH_PHY is disabled, the local phy_addr variable never
> gets initialized causes random behavior at runtime and a gcc warning. So
> set it by default to the stored phy address.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> drivers/net/designware.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
Applied (with minimal changes to the commit message which is missing
a 'which" or so), thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I see that Microsoft's campaign to destroy all knowledge of any
operating environment but its own environment-of-the-year has
succeeded in creating a generation of users who don't understand the
concept of a shell...
-- L. Peter Deutsch in <m0x5jNX-000R2UC@lamp.aladdin.com>
next prev parent reply other threads:[~2011-07-25 20:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 15:19 [U-Boot] [PATCH] net: designware: fix unused warning when CONFIG_DW_AUTONEG is enabled Mike Frysinger
2011-06-02 15:19 ` [U-Boot] [PATCH] net: designware: fix uninitialized phy_addr usage Mike Frysinger
2011-06-06 4:21 ` Vipin Kumar
2011-07-25 20:21 ` Wolfgang Denk [this message]
2011-06-06 4:21 ` [U-Boot] [PATCH] net: designware: fix unused warning when CONFIG_DW_AUTONEG is enabled Vipin Kumar
2011-07-25 20:20 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725202146.8622B138EED4@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox