public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] post: fix indendation/brace confusion
Date: Tue, 26 Jul 2011 16:57:54 +0200	[thread overview]
Message-ID: <20110726145754.1C043138EED4@gemini.denx.de> (raw)
In-Reply-To: <1310667306-24948-1-git-send-email-vapier@gentoo.org>

Dear Mike Frysinger,

In message <1310667306-24948-1-git-send-email-vapier@gentoo.org> you wrote:
> From: James Kosin <jkosin@intcomgrp.com>
> 
> The post.c code is missing braces around the pass case, and as a
> result, the diagnostic function will post both fail and pass for
> a failed test.  The reason for this bug is probably the incorrect
> indentation used, so when reading the code it seems like there
> are proper braces.
> 
> Indent the code to the correct depth and put proper braces around
> the "else" branch of the "if" statement.
> 
> Signed-off-by: James Kosin <jkosin@intcomgrp.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  post/post.c |   24 ++++++++++++------------
>  1 files changed, 12 insertions(+), 12 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The speed of time is one second per second.

      parent reply	other threads:[~2011-07-26 14:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-14 18:15 [U-Boot] [PATCH] post: fix indendation/brace confusion Mike Frysinger
2011-07-14 19:39 ` James Kosin
2011-07-26 14:57 ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110726145754.1C043138EED4@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox