From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Wed, 10 Aug 2011 21:34:29 -0400 Subject: [U-Boot] [u-boot-release] [Patch v2] powerpc/eeprom: cleanup mac command In-Reply-To: <4E432FFE.9040308@freescale.com> References: <1312988191-26950-1-git-send-email-yorksun@freescale.com> <4E432FFE.9040308@freescale.com> Message-ID: <201108102134.30546.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, August 10, 2011 21:27:28 Tabi Timur-B04825 wrote: > York Sun wrote: > > Change the help message to be more helpful. Print argument format. > > Fix MAX_NUM_PORTS to comply with v1 NXID format. > > > > Signed-off-by: York Sun > > Could you also fix the commands so that they take a number in decimal > instead of hex? > > > e.mac[index][i] = simple_strtoul(p, &p, 16); > > ... > > e.mac_count = simple_strtoul(argv[2], NULL, 16); > > I know U-Boot uses hex for everything, but it doesn't make sense for > this command. change it to 0 and then both should work -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20110810/07f1559c/attachment.pgp