From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Mon, 15 Aug 2011 10:08:21 +0200
Subject: [U-Boot] [PATCH 1/3] ARM: Clean arch/arm/lib/cache.c
In-Reply-To: <4E48C42B.5050906@atmel.com>
References: <1313029189-18536-1-git-send-email-hong.xu@atmel.com>
	<201108110638.50692.marek.vasut@gmail.com>
	<4E48C42B.5050906@atmel.com>
Message-ID: <201108151008.21454.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, August 15, 2011 09:00:59 AM Hong Xu wrote:
> Hi Marek,
> 
> On 08/11/2011 12:38 PM, Marek Vasut wrote:
> > On Thursday, August 11, 2011 04:19:45 AM Hong Xu wrote:
> >> The default cache operations defined in arch/arm/lib/cache.c
> >> do not perform any real cache operation, and instead a WARNING
> >> will be emitted.
> >> 
> >> Signed-off-by: Hong Xu<hong.xu@atmel.com>
> >> Tested-by: Elen Song<elen.song@atmel.com>
> >> CC: Albert Aribaud<albert.u.boot@aribaud.net>
> >> CC: Aneesh V<aneesh@ti.com>
> >> CC: Marek Vasut<marek.vasut@gmail.com>
> >> CC: Reinhard Meyer<u-boot@emk-elektronik.de>
> >> CC: Heiko Schocher<hs@denx.de>
> >> ---
> >> 
> >>   arch/arm/lib/cache.c |   55
> >> 
> >> ++++++++++++++++++++++++++++--------------------- 1 files changed, 31
> >> insertions(+), 24 deletions(-)
> >> 
> >> diff --git a/arch/arm/lib/cache.c b/arch/arm/lib/cache.c
> >> index 92b61a2..6af05ec 100644
> >> --- a/arch/arm/lib/cache.c
> >> +++ b/arch/arm/lib/cache.c
> >> @@ -20,36 +20,43 @@
> >> 
> >>    * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> >>    * MA 02111-1307 USA
> >>    */
> >> 
> >> +#include<linux/compiler.h>
> >> +#include<common.h>
> >> 
> >> -/* for now: just dummy functions to satisfy the linker */
> >> +#define EMIT_WARNING printf("WARNING: %s - CPU cache operation is not "
> >> \ +"implemented!\n", __func__)
> > 
> > Maybe use debug() ? Or make the emission of warning conditional, somehow
> > I have the feeling this will make some people unhappy.
> 
> Just my feelings: It's noisy but it'll give strong message to the user
> even if the DEBUG is not opened :-)

That's not my point, it'll likely become noisy on many boards where cache 
flushing/invalidating isn't necessary and where is wasn't noisy before and noone 
cared for it not being implemented.

I'd prefer to see other people thoughts on this.

Cheers
> 
> BR,
> Eric
> 
> > Otherwise looks nice and clean.
> > 
> >> -#include<common.h>
> >> +/*
> 
> [...]