From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/8] POST/arm: adaptations needed for POST on ARM to work
Date: Thu, 18 Aug 2011 12:07:06 +0200 [thread overview]
Message-ID: <201108181207.06970.marek.vasut@gmail.com> (raw)
In-Reply-To: <201108161403.55405.vapier@gentoo.org>
On Tuesday, August 16, 2011 08:03:54 PM Mike Frysinger wrote:
> On Monday, August 15, 2011 05:09:42 Valentin Longchamp wrote:
> > On 08/14/2011 09:07 PM, Mike Frysinger wrote:
> > > On Wednesday, August 03, 2011 08:37:00 Valentin Longchamp wrote:
> > >> --- a/include/post.h
> > >> +++ b/include/post.h
> > >>
> > >> +/*
> > >> + * some ARM implementations have to use gd->ram_size, since POST_WORD
> > >> is + * defined in RAM
> > >> + */
> > >> +DECLARE_GLOBAL_DATA_PTR;
> > >
> > > i'm not sure about this. no other header has been allowed to do this
> > > in the past, and i dont think we should start now.
> >
> > OK. Then we should move the post_word_load and post_word_store function
> > to post/post.c. Would this be accepted ?
>
> that would add overhead that most people dont need. i guess the only other
> option would be to add a CONFIG_POST_EXTERNAL_WORD_FUNCS and then post.h
> would just define the two funcs as externs. it'd be up to the board
> porters to define them however they want.
> -mike
We don't want externs. Why would moving it into post.c introduce any overhead ?
next prev parent reply other threads:[~2011-08-18 10:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 12:36 [U-Boot] [PATCH 0/8 RFC] POST: support for km_arm and mem_regions test definition Valentin Longchamp
2011-08-03 12:37 ` [U-Boot] [PATCH 1/8] POST/arm: adaptations needed for POST on ARM to work Valentin Longchamp
2011-08-14 19:07 ` Mike Frysinger
2011-08-15 9:09 ` Valentin Longchamp
2011-08-16 18:03 ` Mike Frysinger
2011-08-18 10:07 ` Marek Vasut [this message]
2011-08-18 14:31 ` Mike Frysinger
2011-08-18 17:01 ` Marek Vasut
2011-08-18 17:42 ` Mike Frysinger
2011-08-03 12:37 ` [U-Boot] [PATCH 2/8] POST: add post_log_res field for post results in global data Valentin Longchamp
2011-08-18 10:39 ` Marek Vasut
2011-08-18 11:00 ` Valentin Longchamp
2011-08-18 12:56 ` Marek Vasut
2011-08-03 12:37 ` [U-Boot] [PATCH 3/8] POST: make env test flags fetching optional Valentin Longchamp
2011-08-03 12:37 ` [U-Boot] [PATCH 4/8] POST: drivers/memory.c coding style cleanup Valentin Longchamp
2011-08-14 19:14 ` Mike Frysinger
2011-08-03 12:37 ` [U-Boot] [PATCH 5/8] POST: add new memory regions test Valentin Longchamp
2011-08-03 12:37 ` [U-Boot] [PATCH 6/8] POST/km_arm: add POST memory tests infrastructure Valentin Longchamp
2011-08-14 19:49 ` Mike Frysinger
2011-08-15 9:10 ` Valentin Longchamp
2011-08-18 10:44 ` Marek Vasut
2011-09-02 15:25 ` Mike Frysinger
2011-08-03 12:37 ` [U-Boot] [PATCH 7/8] km_arm: change CONFIG_SYS_TEXT_BASE to end of RAM Valentin Longchamp
2011-08-03 12:37 ` [U-Boot] [PATCH 8/8] km_arm: enable POST for these boards Valentin Longchamp
2011-08-04 10:36 ` Sergei Shtylyov
2011-08-15 9:11 ` Valentin Longchamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108181207.06970.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox