[U-Boot] [PATCH 1/8] POST/arm: adaptations needed for POST on ARM to work

Mike Frysinger
2011-08-16T18:03:54Z

On Monday, August 15, 2011 05:09:42 Valentin Longchamp wrote:
> On 08/14/2011 09:07 PM, Mike Frysinger wrote:
> > On Wednesday, August 03, 2011 08:37:00 Valentin Longchamp wrote:
> >> --- a/include/post.h
> >> +++ b/include/post.h
> >>
> >> +/*
> >> + * some ARM implementations have to use gd->ram_size, since POST_WORD
> >> is + * defined in RAM
> >> + */
> >> +DECLARE_GLOBAL_DATA_PTR;
> >
> > i'm not sure about this. no other header has been allowed to do this in
> > the past, and i dont think we should start now.
>
> OK. Then we should move the post_word_load and post_word_store function to
> post/post.c. Would this be accepted ?

that would add overhead that most people dont need. i guess the only other
option would be to add a CONFIG_POST_EXTERNAL_WORD_FUNCS and then post.h would
just define the two funcs as externs. it'd be up to the board porters to
define them however they want.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110816/73142da2/attachment.pgp