[U-Boot] [PATCH 6/8] POST/km_arm: add POST memory tests infrastructure

Mike Frysinger
2011-09-02T15:25:20Z

On Thursday, August 18, 2011 06:44:34 Marek Vasut wrote:
> On Sunday, August 14, 2011 09:49:27 PM Mike Frysinger wrote:
> > On Wednesday, August 03, 2011 08:37:05 Valentin Longchamp wrote:
> > > This patch adds a board support for km_arm in the POST framework.
> > > It consists of a memory test configuration with the redefinition of
> > > the arch_memory_test_prepare function.
> > >
> > > Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> > > Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> > > ---
> > >
> > > post/board/km_arm/Makefile | 29 +++++++++++++++++++++++++++++
> > > post/board/km_arm/memory.c | 37
> > > +++++++++++++++++++++++++++++++++++++
> >
> > i'm not sure post/board/<board>/ is something we want to continue.
> > putting the post logic into your normal board/<board>/ dir works fine.
> > might i suggest board/km_arm/post.c ...
>
> post/board/... seems fine to me actually ... there might be more post tests
> for the board so poluting usual board directory would be stupid.

no it wouldnt. post tests that are board specific belong in the board
specific location: board/<board>/. creating a mirror of that existing
hierarchy is stupid, and most board dirs have very few files, so there really
isn't all that much to clutter up in the first place.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110902/50dd8add/attachment.pgp