From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] IDE: Fix anti-aliasing in cmd_ide.c
Date: Sat, 20 Aug 2011 14:10:00 -0400 [thread overview]
Message-ID: <201108201410.01638.vapier@gentoo.org> (raw)
In-Reply-To: <1313846925-31212-4-git-send-email-marek.vasut@gmail.com>
On Saturday, August 20, 2011 09:28:44 Marek Vasut wrote:
> - ulong iobuf[ATA_SECTORWORDS];
> unsigned char c;
> - hd_driveid_t *iop = (hd_driveid_t *)iobuf;
> + hd_driveid_t iop __attribute__((aligned(4)));
gcc takes care of making sure the hd_driveid_t struct has proper alignment on
the stack. i see it has at least one unsigned int in there, so that gets you
4byte alignment. so drop the attribute.
also, same comment as the other patch ... please change your log/summary to
say "fix strict aliasing violations".
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110820/97af01ef/attachment.pgp
prev parent reply other threads:[~2011-08-20 18:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-20 13:28 [U-Boot] [PATCH 1/4] PXA: Fix Lubbock, remove redundant parenthesis Marek Vasut
2011-08-20 13:28 ` [U-Boot] [PATCH 2/4] PXA: Fix CSB226, fix monitor length Marek Vasut
2011-08-20 13:28 ` [U-Boot] [PATCH 3/4] USB: Fix anti-aliasing complaints in OHCI-HCD Marek Vasut
2011-08-20 13:34 ` Marek Vasut
2011-08-20 18:07 ` Mike Frysinger
2011-08-20 18:56 ` Marek Vasut
2011-08-20 13:28 ` [U-Boot] [PATCH 4/4] IDE: Fix anti-aliasing in cmd_ide.c Marek Vasut
2011-08-20 18:10 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108201410.01638.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox