public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] USB: Fix anti-aliasing complaints in OHCI-HCD
Date: Sat, 20 Aug 2011 20:56:41 +0200	[thread overview]
Message-ID: <201108202056.41937.marek.vasut@gmail.com> (raw)
In-Reply-To: <201108201407.50669.vapier@gentoo.org>

On Saturday, August 20, 2011 08:07:49 PM Mike Frysinger wrote:
> On Saturday, August 20, 2011 09:28:43 Marek Vasut wrote:
> > -	__u32 datab[4];
> > +	__u8 datab[16] __attribute__((aligned(4)));
> > 
> >  	__u8 *data_buf = (__u8 *)datab;
> 
> leverage a union to avoid attributes:
> union {
> 	__u32 u32[4];
> 	__u8 u8[16];
> } datab;
> __u8 *data_buf = datab.u8;
> 
> also, it isn't "anti-aliasing complaints", it's "fix strict aliasing
> violations".  "anti-aliasing" is something completely different in the
> computing world :p.

Well I guess my brain just saw the compiler output differently ... thanks for the 
catch.

> -mike

  reply	other threads:[~2011-08-20 18:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-20 13:28 [U-Boot] [PATCH 1/4] PXA: Fix Lubbock, remove redundant parenthesis Marek Vasut
2011-08-20 13:28 ` [U-Boot] [PATCH 2/4] PXA: Fix CSB226, fix monitor length Marek Vasut
2011-08-20 13:28 ` [U-Boot] [PATCH 3/4] USB: Fix anti-aliasing complaints in OHCI-HCD Marek Vasut
2011-08-20 13:34   ` Marek Vasut
2011-08-20 18:07   ` Mike Frysinger
2011-08-20 18:56     ` Marek Vasut [this message]
2011-08-20 13:28 ` [U-Boot] [PATCH 4/4] IDE: Fix anti-aliasing in cmd_ide.c Marek Vasut
2011-08-20 18:10   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108202056.41937.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox