public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] cmd_sf: add "update" subcommand to do smart SPI flash update
Date: Sun, 21 Aug 2011 12:34:18 -0400	[thread overview]
Message-ID: <201108211234.19500.vapier@gentoo.org> (raw)
In-Reply-To: <CAPnjgZ2odYjfi_CZO0Hn8H8PKVWq+2M0d4ySPVU0foyzbzL4Kg@mail.gmail.com>

On Sunday, August 21, 2011 06:27:16 Simon Glass wrote:
> On Sat, Aug 20, 2011 at 4:35 PM, Mike Frysinger wrote:
> > +static int spi_flash_update(struct spi_flash *flash, u32 offset,
> > +               size_t len, const char *buf)
> > +{
> > +       const char *err_oper = NULL;
> > +       char *cmp_buf;
> > +       const char *end = buf + len;
> > +       size_t todo;            /* number of bytes to do in this pass */
> > +       size_t skipped;         /* statistics */
> > +
> > +       cmp_buf = malloc(flash->sector_size);
> > +       if (cmp_buf) {
> > +               for (skipped = 0; buf < end; buf += todo, offset += todo)
> > {
> 
> Oops I got this wrong:
> 
> for (skipped = 0; buf < end && !err_oper; buf += todo, offset += todo) {
> 
> (or if (err_oper) break in the loop)

you can send a v5 and i'll just replace it in my tree :)

or a diff and i'll just merge it locally ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110821/ebbe2e78/attachment.pgp 

      reply	other threads:[~2011-08-21 16:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-19 19:28 [U-Boot] [PATCH v3] Add 'sf update' command to do smart SPI flash update Simon Glass
2011-08-19 21:15 ` Mike Frysinger
2011-08-19 21:25   ` Simon Glass
2011-08-19 22:28     ` Mike Frysinger
2011-08-23 22:01       ` Simon Glass
2011-08-23 22:16         ` Mike Frysinger
2011-08-24  3:41           ` Che-liang Chiou
2011-08-24  4:11             ` Simon Glass
2011-08-20 22:35 ` [U-Boot] [PATCH v4] cmd_sf: add "update" subcommand " Mike Frysinger
2011-08-20 23:04   ` Marek Vasut
2011-08-21 10:37     ` Simon Glass
2011-08-21 16:35       ` Mike Frysinger
2011-08-22 22:53         ` Simon Glass
2011-08-21 10:27   ` Simon Glass
2011-08-21 16:34     ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108211234.19500.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox