From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] new tool mkenvimage: generates an env image from an arbitrary config file
Date: Sun, 21 Aug 2011 21:09:47 -0400 [thread overview]
Message-ID: <201108212109.48533.vapier@gentoo.org> (raw)
In-Reply-To: <1312885889-20222-1-git-send-email-david.wagner@free-electrons.com>
On Tuesday, August 09, 2011 06:31:29 David Wagner wrote:
> +extern uint32_t crc32 (uint32_t, const unsigned char *, unsigned int);
does including u-boot/crc.h work ?
> +static void usage(char *exec_name)
const char *exec_name
> + char *txt_filename = NULL, *bin_filename = NULL;
mark them both const ?
> + dataptr = calloc(datasize, sizeof(*dataptr));
you zero-ed it out here ...
> + /* Pad the environnment with the padding byte */
> + memset(envptr, padbyte, envsize);
... then manually filled it with a byte. just use malloc() instead of
calloc() and avoid that zero.
> + memcpy((uint32_t*) dataptr, &targetendian_crc, sizeof(uint32_t));
i dont think that cast is necessary. just punt it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110821/d79e0d6e/attachment.pgp
next prev parent reply other threads:[~2011-08-22 1:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 14:49 [U-Boot] [PATCH] new tool mkenvimage: generates an env image from an arbitrary config file David Wagner
2011-08-05 15:23 ` Thomas Petazzoni
2011-08-05 16:23 ` [U-Boot] [PATCHv2] " David Wagner
2011-08-06 11:18 ` Mike Frysinger
2011-08-08 8:16 ` David Wagner
2011-08-08 8:46 ` Albert ARIBAUD
2011-08-08 8:56 ` David Wagner
2011-08-08 18:53 ` Mike Frysinger
2011-08-09 10:31 ` [U-Boot] [PATCH] " David Wagner
2011-08-22 1:09 ` Mike Frysinger [this message]
2011-08-24 22:12 ` Wolfgang Denk
2011-08-29 12:06 ` [U-Boot] [PATCHv4] " David Wagner
2011-08-30 19:12 ` Mike Frysinger
2011-08-30 19:34 ` Wolfgang Denk
2011-09-01 15:57 ` [U-Boot] [PATCHv5] " David Wagner
2011-09-01 17:47 ` Mike Frysinger
2011-09-02 8:47 ` [U-Boot] [PATCH] " David Wagner
2011-09-02 8:48 ` David Wagner
2011-09-02 8:48 ` [U-Boot] [PATCHv6] " David Wagner
2011-09-02 14:35 ` Mike Frysinger
2011-09-26 12:10 ` Thomas Petazzoni
2011-09-26 13:26 ` [U-Boot] [PATCHv7] " David Wagner
2011-09-30 7:31 ` [U-Boot] [PATCHv8] " David Wagner
2011-10-06 21:17 ` Wolfgang Denk
2011-10-13 18:45 ` [U-Boot] [PATCHv9] " David Wagner
2011-10-14 8:21 ` Detlev Zundel
2011-10-14 17:16 ` [U-Boot] [PATCHv10] " David Wagner
2011-10-19 8:22 ` Thomas Petazzoni
2011-10-23 20:44 ` Wolfgang Denk
2011-10-31 0:49 ` Mike Frysinger
2011-11-22 8:48 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108212109.48533.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox