From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 22 Aug 2011 14:28:04 +0200 Subject: [U-Boot] [PATCH 07/14] MX5: efikamx: make use of GPIO framework In-Reply-To: <4E523A68.6020302@denx.de> References: <1313922509-10083-1-git-send-email-sbabic@denx.de> <201108211354.18969.marek.vasut@gmail.com> <4E523A68.6020302@denx.de> Message-ID: <201108221428.04470.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, August 22, 2011 01:15:52 PM Stefano Babic wrote: > On 08/21/2011 01:54 PM, Marek Vasut wrote: > > On Sunday, August 21, 2011 12:28:22 PM Stefano Babic wrote: > >> Signed-off-by: Stefano Babic > >> CC: Marek Vasut > >> --- > > Hi Marek, > > >> + gpio_direction_output(IOMUX_TO_GPIO(MX51_PIN_CSI1_HSYNC), 0); > > > > I'd be careful about the LEDs here. > > Well, I have seen the LEDs were not explicitely initialized. Maybe it > relies on the default value of the DR register, that should be zero. > > > Anyway, I'll try to test it sometimes soon > > (begining of next week is ok?). > > Of course, yes. Thanks for testing ! Well damn, my efikamx didn't arrive today as planned. You can merge it, according to the schematics it looks ok. Cheers > > Best regards, > Stefano Babic