From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available
Date: Mon, 22 Aug 2011 17:02:47 +0200 [thread overview]
Message-ID: <201108221702.47352.marek.vasut@gmail.com> (raw)
In-Reply-To: <4E526EFF.50509@hale.at>
On Monday, August 22, 2011 05:00:15 PM Helmut Raiger wrote:
> On 08/22/2011 04:00 PM, Marek Vasut wrote:
> > + u32 pdr0 = __REG(CCM_PDR0);
> > Can't we do readl() here?
> >
> >> +
> >> + /* divided by HSP_PODF in PDR0 */
> >> + freq /= ((pdr0>> 11)& 0x7) + 1;
> >
> > Um, don't we have defined constants for those magic numbers already?
>
> Masks are not defined for i.MX31 (imx-regs.h), so I simply followed the
> code, which was in the file. The generic.c file for MX35 however is a
> different story.
>
> To keep things simple, I suggest we leave it at that for now.
And noone's gonna fix it later. No please, define the proper constants please.
Thanks in advance
>
> Helmut
>
>
>
>
>
> --
> Scanned by MailScanner.
next prev parent reply other threads:[~2011-08-22 15:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 13:41 [U-Boot] Moving mx3fb.c to CONFIG_VIDEO Helmut Raiger
2011-08-22 13:41 ` [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available Helmut Raiger
2011-08-22 14:00 ` Marek Vasut
2011-08-22 15:00 ` Helmut Raiger
2011-08-22 15:02 ` Marek Vasut [this message]
2011-08-22 15:51 ` Helmut Raiger
2011-08-22 16:02 ` Marek Vasut
2011-08-22 16:39 ` Marek Vasut
2011-08-24 6:55 ` Helmut Raiger
2011-08-24 12:35 ` Marek Vasut
2011-08-22 16:22 ` Stefano Babic
2011-08-22 13:41 ` [U-Boot] [PATCH 2/2] mx3fb: move to CONFIG_VIDEO to support videomodes Helmut Raiger
2011-08-22 17:13 ` Stefano Babic
2011-08-24 11:53 ` Helmut Raiger
2011-08-24 15:34 ` Helmut Raiger
2011-08-24 15:45 ` Stefano Babic
[not found] ` <4E549AC3.3060909@hale.at>
2011-08-24 11:57 ` Helmut Raiger
2011-08-22 16:04 ` [U-Boot] Moving mx3fb.c to CONFIG_VIDEO Stefano Babic
2011-09-05 11:47 ` [U-Boot] Version 2 of 'Moving mx3fb to CONFIG_VIDEO' Helmut Raiger
2011-09-05 11:47 ` [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available Helmut Raiger
2011-09-05 13:10 ` Marek Vasut
2011-09-05 11:47 ` [U-Boot] [PATCH 2/2] Moving mx3fb.c to CONFIG_VIDEO Helmut Raiger
2011-09-20 11:44 ` Stefano Babic
2011-09-20 12:36 ` Anatolij Gustschin
2011-09-20 13:09 ` Stefano Babic
2011-09-21 8:02 ` Helmut Raiger
2011-09-21 14:58 ` Stefano Babic
2011-09-28 17:24 ` Anatolij Gustschin
2011-10-13 9:16 ` [U-Boot] [PATCH v3 1/2] mx31: make HSP clock for mx3fb driver available Anatolij Gustschin
2011-10-13 9:23 ` Anatolij Gustschin
2011-10-13 9:40 ` Stefano Babic
2011-10-14 7:02 ` Anatolij Gustschin
2011-10-13 9:16 ` [U-Boot] [PATCH v3 2/2] video: Moving mx3fb.c to CONFIG_VIDEO Anatolij Gustschin
2011-10-14 6:37 ` Helmut Raiger
2011-10-14 7:00 ` Anatolij Gustschin
2011-10-14 7:04 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108221702.47352.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox