From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Mon, 22 Aug 2011 17:02:47 +0200
Subject: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver
	available
In-Reply-To: <4E526EFF.50509@hale.at>
References: <1314020497-30897-1-git-send-email-helmut.raiger@hale.at>
	<201108221600.39161.marek.vasut@gmail.com> <4E526EFF.50509@hale.at>
Message-ID: <201108221702.47352.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, August 22, 2011 05:00:15 PM Helmut Raiger wrote:
> On 08/22/2011 04:00 PM, Marek Vasut wrote:
> > +	u32 pdr0 = __REG(CCM_PDR0);
> > Can't we do readl() here?
> > 
> >> +
> >> +	/* divided by HSP_PODF in PDR0 */
> >> +	freq /= ((pdr0>>  11)&  0x7) + 1;
> > 
> > Um, don't we have defined constants for those magic numbers already?
> 
> Masks are not defined for i.MX31 (imx-regs.h), so I simply followed the
> code, which was in the file. The generic.c file for MX35 however is a
> different story.
> 
> To keep things simple, I suggest we leave it at that for now.

And noone's gonna fix it later. No please, define the proper constants please.

Thanks in advance
> 
> Helmut
> 
> 
> 
> 
> 
> --
> Scanned by MailScanner.