From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 22 Aug 2011 18:45:06 +0200 Subject: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100 In-Reply-To: <201108221242.34774.vapier@gentoo.org> References: <201108221807.26804.marek.vasut@gmail.com> <201108221242.34774.vapier@gentoo.org> Message-ID: <201108221845.06263.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, August 22, 2011 06:42:33 PM Mike Frysinger wrote: > On Monday, August 22, 2011 12:07:26 Marek Vasut wrote: > > On Monday, August 22, 2011 06:02:26 PM Mike Frysinger wrote: > > > On Monday, August 22, 2011 01:11:57 Ajay Bhargav wrote: > > > > + darmdfec = malloc(sizeof(struct armdfec_device)); > > > > > > sizeof(*darmdfec) > > > > Why are you against sizeof(struct ...) ? > > imo, it holds up against bit rot easier and the code is clearer OTOH, you don't have to look up what type of ptr it is if you use struct ... Cheers > -mike