From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] add dm9000 eeprom read/write command
Date: Tue, 23 Aug 2011 09:42:42 -0400 [thread overview]
Message-ID: <201108230942.44871.vapier@gentoo.org> (raw)
In-Reply-To: <D1E2654D-29E6-41BB-8489-BD4D405A04E9@armadeus.org>
On Tuesday, August 23, 2011 01:15:25 Eric Jarrige wrote:
> On 22 ao?t 2011, at 23:55, Mike Frysinger wrote:
> > On Monday, August 22, 2011 17:37:42 Eric Jarrige wrote:
> >> +#if (!defined(CONFIG_DM9000_NO_SROM) && defined(CONFIG_DRIVER_DM9000))
> >
> > why is this necessary ?
>
> the methods dm9000_read_srom_word()/dm9000_write_srom_word() need these
> conditions to be compiled in dm9000x.c Therefore this avoid dead code
> and/or compilation failure if these conditions are not met.
my point is that it is user error to select CONFIG_CMD_DM9000EE but not select
the DM9000 settings. in your case, the user silently gets a build that makes
no sense. in my case, they're forced to fix things.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110823/87b1505c/attachment.pgp
next prev parent reply other threads:[~2011-08-23 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 21:37 [U-Boot] [PATCH] add dm9000 eeprom read/write command Eric Jarrige
2011-08-22 21:55 ` Mike Frysinger
2011-08-23 5:15 ` Eric Jarrige
2011-08-23 13:42 ` Mike Frysinger [this message]
2011-08-23 14:21 ` Stefano Babic
2011-08-24 5:36 ` Eric Jarrige
2011-08-23 9:34 ` Stefano Babic
2011-10-06 21:49 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108230942.44871.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox