public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer
Date: Tue, 23 Aug 2011 22:16:25 +0200	[thread overview]
Message-ID: <20110823201625.6ACFD201520@gemini.denx.de> (raw)
In-Reply-To: <201108231447.39934.vapier@gentoo.org>

Dear Mike Frysinger,

In message <201108231447.39934.vapier@gentoo.org> you wrote:
>
> then people would simply do:
> 	DMA_DECLARE_BUFFER(char, sec_buf, SECTOR_SIZE);
>
> but i'm not sure this is better than the proposed:
> 	char *sec_buf = dma_buffer_alloca(SECTOR_SIZE);
>
> i'd have to look at the code gcc generates to see if it is simply the same ... 
> in which case i'd stick with the latter as it's more natural to people.

Even if the code is different the former is so ugly that chances for
it to go into mainline are _really_ small.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Just because your doctor has a name for your condition  doesn't  mean
he knows what it is.

      parent reply	other threads:[~2011-08-23 20:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 20:12 [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer Anton Staaf
2011-08-22 21:42 ` Wolfgang Denk
2011-08-22 21:48   ` Anton Staaf
2011-08-23 17:23     ` Mike Frysinger
2011-08-23 17:58       ` Anton Staaf
2011-08-23 18:32         ` Mike Frysinger
2011-08-23 18:48           ` Anton Staaf
2011-08-23 18:55             ` Mike Frysinger
2011-08-23 18:57               ` Anton Staaf
2011-08-23 20:18             ` Wolfgang Denk
2011-08-23 20:24               ` Anton Staaf
2011-08-23 18:39     ` Wolfgang Denk
2011-08-23 18:47       ` Mike Frysinger
2011-08-23 18:52         ` Anton Staaf
2011-08-23 20:16         ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110823201625.6ACFD201520@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox