From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 23 Aug 2011 22:16:25 +0200 Subject: [U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer In-Reply-To: <201108231447.39934.vapier@gentoo.org> References: <1314043924-22130-1-git-send-email-robotboy@chromium.org> <20110823183948.72B3711F9E62@gemini.denx.de> <201108231447.39934.vapier@gentoo.org> Message-ID: <20110823201625.6ACFD201520@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Frysinger, In message <201108231447.39934.vapier@gentoo.org> you wrote: > > then people would simply do: > DMA_DECLARE_BUFFER(char, sec_buf, SECTOR_SIZE); > > but i'm not sure this is better than the proposed: > char *sec_buf = dma_buffer_alloca(SECTOR_SIZE); > > i'd have to look at the code gcc generates to see if it is simply the same ... > in which case i'd stick with the latter as it's more natural to people. Even if the code is different the former is so ugly that chances for it to go into mainline are _really_ small. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Just because your doctor has a name for your condition doesn't mean he knows what it is.